search

neveldo / jQuery-Mapael

jQuery plugin based on raphael.js that allows you to display dynamic vector maps
https://www.vincentbroute.fr/mapael/
MIT License
1.01k stars 195 forks source link

Fixed the update event when plotsOn option used #265

Closed Licht-T closed 7 years ago

Licht-T commented 8 years ago

Hi,

Previously, I created the pull request about 'plotsOn' option. But it had the bug when the update event. Here is the fix pull request.

neveldo commented 8 years ago

Hello,

I don't understand, in the diff, it seems there is more than just a fix, as there is code modifications related to links between plots ?

Licht-T commented 8 years ago

Hello,

You are right. This is related to links between plots. Before modifications, we cannot make a link between plots which is created by plotsOn option.

Indigo744 commented 7 years ago

@Licht-T Can you provide an example? Like a JSFiddle for instance? Then we can review and merge your PR. Thanks!

Indigo744 commented 7 years ago

I reviewed the change and it's OK.

I simply factorize the center computation to reduce same code.

Thank you for your contribution :)

Licht-T commented 7 years ago

@Indigo744 Excuse me, but I didn't notice your mention! Thanks for your review!