search

neverhood311 / Stop-motion-OBJ

A Blender add-on for importing a sequence of OBJ meshes as frames
GNU General Public License v3.0
687 stars 52 forks source link

Fix ConvertToMeshSequence operator #160

Closed Failxxx closed 2 years ago

Failxxx commented 2 years ago

There is an error in the ConvertToMeshSequence operator. When converting an object into a mesh sequence, the following exception is thrown:

/home/hnum/.config/blender/3.0/scripts/addons/Stop-motion-OBJ/panels.py:44
Info: See 'panels.py' in the text editor

Python: Traceback (most recent call last):
  File "/home/hnum/.config/blender/3.0/scripts/addons/Stop-motion-OBJ/panels.py", line 453, in execute
    msObj = newMeshSequence('emptyMesh')
TypeError: newMeshSequence() takes 0 positional arguments but 1 was given

location: <unknown location>:-1
Error: Python: Traceback (most recent call last):
  File "/home/hnum/.config/blender/3.0/scripts/addons/Stop-motion-OBJ/panels.py", line 453, in execute
    msObj = newMeshSequence('emptyMesh')
TypeError: newMeshSequence() takes 0 positional arguments but 1 was given

location: <unknown location>:-1

I think it comes from PR #155.

It seems to be working as intended now.

neverhood311 commented 2 years ago

Thanks for finding this! We added the parameter to newMeshSequence() in #154 but when I manually reverted that PR, I guess I forgot the one you found.

One minor change is needed: you need to increment the version numbers found in version.py and __init__.py. Just bump them to .alpha.22, then I can merge your PR