nevillegrech / MadMax

Ethereum Static Vulnerability Detector for Gas-Focussed Vulnerabilities
BSD 3-Clause "New" or "Revised" License
130 stars 16 forks source link

Which problems to expect when using the current gigahorse-toolchain (#8d7c33b)? #5

Open gsalzer opened 3 years ago

gsalzer commented 3 years ago

When using MadMax with the linked branch of gigahorse-toolchain (#f89ccb4) and souffle 2.0.2-1538-geb8c6f6e4, gigahorse.py fails with errors like

Compiling madmax.dl to C++ program and executable
Error: Atom's argument type is not a subtype of its declared type in file data_structures.dl at line 12
Variable_Value(resVar, @add_256(val0, val1)) :-
-----------------------^------------------------
The argument's declared type is Value in file decompiler_imports.dl at line 57
.decl Variable_Value(var: Variable, value: Value)

Apparently there is a mismatch of versions between gigahorse and souffle.

Replacing gigahorse by the current version resolves the problem.

Is it safe for madmax to replace gigahorse #f89ccb4 by #8d7c33b, or should I expect problems?