Function inliner refactor

sifislag commented 2 months ago

Refactor inliner to:

allow the inlining of functions with more than one returns, helping with some storage patterns
better heuristics, attempt to avoid inlining larger methods when it wouldn't benefit the analysis
make the inliner easier to debug

Results:

solc08-over10k:

ANALYTIC: Analytics_NonModeledMSTORE
may24-08-clientsmaster-800 (common): 22374 (+5.27%)
may24-08-clientsinliner2-800 (common): 21254

ANALYTIC: Analytics_NonModeledMLOAD
may24-08-clientsmaster-800 (common): 13460 (+0.9374%)
may24-08-clientsinliner2-800 (common): 13335

ANALYTIC: Analytics_CallToSignature
may24-08-clientsmaster-800 (common): 4288
may24-08-clientsinliner2-800 (common): 4287 (-0.02332%)

ANALYTIC: Analytics_EventSignature
may24-08-clientsmaster-800 (common): 5795
may24-08-clientsinliner2-800 (common): 5795

ANALYTIC: Analytics_PublicFunctionArg
may24-08-clientsmaster-800 (common): 36576
may24-08-clientsinliner2-800 (common): 36418 (-0.432%)

ANALYTIC: Analytics_PublicFunctionArrayArg
may24-08-clientsmaster-800 (common): 2822
may24-08-clientsinliner2-800 (common): 2821 (-0.03544%)

ANALYTIC: Analytics_NonModeledSSTORE
may24-08-clientsmaster-800 (common): 390 (+239.1%)
may24-08-clientsinliner2-800 (common): 115

ANALYTIC: Analytics_NonModeledSLOAD
may24-08-clientsmaster-800 (common): 1348 (+200.9%)
may24-08-clientsinliner2-800 (common): 448

ANALYTIC: Analytics_GlobalVariable
may24-08-clientsmaster-800 (common): 14929
may24-08-clientsinliner2-800 (common): 14925 (-0.02679%)

ANALYTIC: client_time
may24-08-clientsmaster-800 (common): 53744.260494470596 (+3.189%)
may24-08-clientsinliner2-800 (common): 52083.51030373573

ANALYTIC: inline_time
may24-08-clientsmaster-800 (common): 2538.471233844757
may24-08-clientsinliner2-800 (common): 3012.8361172676086 (+18.69%)

viair-dec23

ANALYTIC: Analytics_NonModeledMSTORE
may24-ir-clientsmaster-800 (common): 56269 (+28.99%)
may24-ir-clientsinliner2-800 (common): 43623

ANALYTIC: Analytics_NonModeledMLOAD
may24-ir-clientsmaster-800 (common): 44468 (+9.465%)
may24-ir-clientsinliner2-800 (common): 40623

ANALYTIC: Analytics_CallToSignature
may24-ir-clientsmaster-800 (common): 4518
may24-ir-clientsinliner2-800 (common): 4518

ANALYTIC: Analytics_EventSignature
may24-ir-clientsmaster-800 (common): 4760
may24-ir-clientsinliner2-800 (common): 4759 (-0.02101%)

ANALYTIC: Analytics_PublicFunctionArg
may24-ir-clientsmaster-800 (common): 42854 (-0.01866%)
may24-ir-clientsinliner2-800 (common): 42862

ANALYTIC: Analytics_PublicFunctionArrayArg
may24-ir-clientsmaster-800 (common): 4143
may24-ir-clientsinliner2-800 (common): 4124 (-0.4586%)

ANALYTIC: Analytics_NonModeledSSTORE
may24-ir-clientsmaster-800 (common): 2224 (+17.8%)
may24-ir-clientsinliner2-800 (common): 1888

ANALYTIC: Analytics_NonModeledSLOAD
may24-ir-clientsmaster-800 (common): 3046 (+24.53%)
may24-ir-clientsinliner2-800 (common): 2446

ANALYTIC: Analytics_GlobalVariable
may24-ir-clientsmaster-800 (common): 5200
may24-ir-clientsinliner2-800 (common): 5175 (-0.4808%)

ANALYTIC: client_time
may24-ir-clientsmaster-800 (common): 52351.94763755798
may24-ir-clientsinliner2-800 (common): 55225.69925236702 (+5.489%)

ANALYTIC: inline_time
may24-ir-clientsmaster-800 (common): 2918.6505179405212
may24-ir-clientsinliner2-800 (common): 3836.98495554924 (+31.46%)

github-actions[bot] commented 2 months ago

Test Results (Souffle 2.4)

55 tests ±0 55 :white_check_mark: ±0 37m 41s :stopwatch: + 3m 19s 1 suites ±0 0 :zzz: ±0 1 files ±0 0 :x: ±0

Results for commit fd31be1d. ± Comparison against base commit 35cc700b.

github-actions[bot] commented 2 months ago

Test Results (Souffle 2.3)

55 tests ±0 55 :white_check_mark: ±0 37m 47s :stopwatch: + 3m 39s 1 suites ±0 0 :zzz: ±0 1 files ±0 0 :x: ±0

Results for commit fd31be1d. ± Comparison against base commit 35cc700b.

nevillegrech / gigahorse-toolchain