Closed sifislag closed 1 year ago
42 tests +1 42 :heavy_check_mark: +1 18m 16s :stopwatch: - 8m 56s 1 suites ±0 0 :zzz: ±0 1 files ±0 0 :x: ±0
Results for commit 72745448. ± Comparison against base commit cdd7571b.
42 tests +1 42 :heavy_check_mark: +1 25m 8s :stopwatch: + 6m 3s 1 suites ±0 0 :zzz: ±0 1 files ±0 0 :x: ±0
Results for commit 72745448. ± Comparison against base commit cdd7571b.
Stumbled upon weird behavior when looking at this old issue. It seemed that we were doing a better job with the new shrinking context and the
transfer()
andtransferFrom()
methods were way more complete. However we had some code unreachable at the global level. Turned out the issue was caused by the stack limit of our global analysis being reached. Played around with it and found that 70 was the best value.Benchmark results for 1300 contracts from popular protcols:
It can be noticed that in rare cases it does make a difference.
Results for 1022 viaIR contracts:
Not that affected.