nevinera / quiet_quality

A system for finding and annotating quality issues on your forward diffs
MIT License
12 stars 0 forks source link

Update the Rspec::Parser to ignore simplecov output mixed into the rspec json #91

Closed nevinera closed 1 year ago

nevinera commented 1 year ago

simplecov-html, the default simplecov output formatter, dumps text output into stderr even when rspec is asked for --format json, causing the output stream to be unparseable. While this is truly an issue with simplecov (and I've started a conversation here), we can work around it from our end because the text being written into the output stream is very limited and specific.

So - as part of parsing the output of rspec, look for non-json simplecov output strings and strip them from the text before json-parsing.

You can actually produce this error on this repository in main by running SIMPLECOV=true bin/qq, which totally passes in this branch ;-)