search

nevyn / SPStackedNav

Apache License 2.0
7 stars 0 forks source link

Fix gray overlay/shadow not respecting size changes when changing orientation #11

Open nevyn opened 6 years ago

nevyn commented 6 years ago

When switching between landscape/portrait, the gray overlay retains the old size, and thus doesn't cover the view entirely along the bottom or along the right side of the screen. It needs to use new APIs to detect size class/coordinate space changes instead of orientation changes to adjust the overlay size.

screen shot 2018-03-28 at 7 33 46 pm

portrait broken

Steps to reproduce

  1. Only root VC pushed, stack is empty
  2. Switch to portrait
  3. Push a few view controllers
  4. Rotate to landscape
  5. Pan to navigate, and look at the broken shadow

(and vice versa for broken portrait)