new-day-international / reddit

New Day fork of the code that powers reddit.com
Other
3 stars 1 forks source link

Create/edit space page spacing changes #214

Open inflector opened 10 years ago

inflector commented 10 years ago
caseydriscoll commented 10 years ago

This has already been finished twice now. It may need some tweaks, but I'm gonna need more specifics.

This is how bootstrap.lightnetb.org currently looks. There are bugs, but they should be listed, and not as "rework"

If it does need a "rework", as I brought up a month ago, we'll need a branding and marketing guideline for consistency. Design decisions have been much too arbitrary up until this point.

screen shot 2014-01-17 at 8 01 57 am

inflector commented 10 years ago

Casey, I know the page has been bootstrappified in the whole, but the details haven't been done.

Some examples:

space_settings-look-and-feel

The spacing and margins don't look like anyone has ever set them. They're nonexistent.

This next one may be "in progress" but we need to finish it one way or another. If we're taking the rules out then lets do so.

space_settings-sidebar

Finally, the old version had two columns, the first one was right adjusted, and the second left adjusted. Right now th lines are all on top of each other without any additional separation between lines so it makes it difficult to read.

space_settings-wiki

inflector commented 10 years ago

Perhaps it's time to get that designer now that we're close. It would indeed help at this point, especially for things like this page layout.

caseydriscoll commented 10 years ago

This ticket needs an edit. As it was added:

"Create/edit space page needs visual rework" and "The page doesn't appear to have been redone yet in the bootstrap new style."

...is not a good way to approach bugs. Please consider this in the future as we massage out feature creep. List specifics and only make a ticket if it should be done this sprint. If it is a contentious issue, please bring up a topic of discusison in lightnet.devteam before creating a ticket, as tickets resemple specific work to be finished.

To your added points:

I'm labeling this ticket as "bug". Please update your original content to clearly layout out the specific issues. It is probably helpful to list some info such as machine, OS, browser and screen resolution, especially when dealing with UI bugs.