new-day-international / reddit

New Day fork of the code that powers reddit.com
Other
3 stars 1 forks source link

User Extended Profiles #66

Open memetic007 opened 10 years ago

memetic007 commented 10 years ago

Build editing and display capability for multi-part User Profile. Like Facebook(ish) but better!!!!

ReDo the /user/username page very approximately along the lines of this page:

extendedprofiles

Have the Edit Buttons if it is the Users Own Page, but obviously not, if not.

Use Facebook as an early "thought model" but I would like to get Venessa to give it a good think thru well before we start coding..

ffunch commented 10 years ago

@memetic007 How do you see this fit in in relation to our current priorities? Seems to make sense to do this early, while we're working on Bootstrapifying things.

And, if so, we need some more meat on what we want here, of course. Some geographical information would be obvious, but what else? Education, contact info, political & religious labels, interests?

memetic007 commented 10 years ago

This is the next major feature feature after Notifications. I'd like at least minimal version as part of the January re-launch.

Minimum perhaps just:

Next priority would be:

memetic007 commented 10 years ago

@ffunch work with @caseypatrickdriscoll on getting the minimum version cooked into the Bootstrap UI

ffunch commented 10 years ago

Alright, so there's both how a person is presented to others, and what things they can fill in about themselves.

Currently, when clicking on a user's name, there's no profile in sight, but one sees an "overview", a mix of posts and comments they've posted. And one can chose a "comments" tab which shows recent comments they've posted, or "submitted" which gives just the posts/links. Straightforward, but not particularly clear either, and zero actual information about the person.

So, we'll replace that with something like Jim's graphic at the top. The click on the person's name from anywhere gets us into their public profile. And there are tabs to get to other stuff about the person.

I can see the point of a Reputation tab, even if I don't think we have much to put into it right now. But there I would imagine to later see some kind of history of transactions done, of value provided in one way or another, other than posts.

And the different kinds of posts & comments in a pulldown, that makes sense too.

How about an Activity tab, which an ongoing history of everything they do, including posting posts & comments, voting things up and down, editing their profile, making new spaces, etc.?

ffunch commented 10 years ago

As to geographical profile information, a key thing to decide early is what kind of geo database to attach it to, and to what degree we force it to match.

I have in the past with good success used the MaxMind database. Even the free version covers just about everything.

With something like that we can have pulldown lists of course of countries without any problem. And of states and the equivalent in any country, although there it already starts getting a little tricky, as the different levels aren't equally important in different places. For example, in the US it would be silly to be asked to choose one's county, one would go straight from State to City. And would we want a pulldown of city? Or maybe just a namepicker autocompleter? We of course won't end up with precise coordinates unless we have things pinpointed exactly. And do we even want that? We could maybe also decide that the smallest unit we care about is a metropolitan area, and let people pick which one they want to be affiliated with.

ffunch commented 10 years ago

So, now, how for the profile editing to look to start with?

For one thing, I imagine that the photo selection would belong on a profile edit page, rather than in options.

And don't worry too much about the look, as it needs to be bootstrapified, like everything else. Just give me a bit of feedback on what to call things and if anything else obvious should be there, and whether the tab should go somewhere else.

memetic007 commented 10 years ago

For a minimum profile that looks reasonably good. As Iemntioned above forst addition I'd add would be a list of links with titles for web preexisting biographical/interest info:

On Tue, Dec 17, 2013 at 9:23 AM, Flemming Funch notifications@github.comwrote:

So, now, how for the profile editing to look to start with?

()[http://i.imgur.com/StgBC4h.png]

For one thing, I imagine that the photo selection would belong on a profile edit page, rather than in options.

And don't worry too much about the look, as it needs to be bootstrapified, like everything else. Just give me a bit of feedback on what to call things and if anything else obvious should be there, and whether the tab should go somewhere else.

— Reply to this email directly or view it on GitHubhttps://github.com/new-day-international/reddit/issues/66#issuecomment-30754285 .

Jim Rutt JPR Ventures

myers commented 10 years ago

Reviewing the functionality of this feature:

@ffunch: does that answer your questions?

Looks close to done.

ffunch commented 10 years ago

OK, country list is now in order. "last_name" is "last name". Saving a profile has better feedback now.

myers commented 10 years ago

@ffunch I did a code review of your branch.

repeating country data twice

Could you extract this list and put it in a module so that you don't have to repeat it? Or even better there seems to be already a pycountries module in use by the reddit code: see r2.lib.countries. Use that instead of adding another list of countries.

https://github.com/new-day-international/reddit/compare/master...issue-66-profiles#diff-6c91c71e9d629fec0dc6cc98721937e1R2229 https://github.com/new-day-international/reddit/compare/master...issue-66-profiles#diff-b78e558528b649cc8d66da14329eff3aR626

ffunch commented 10 years ago

Oops, yes, of course. Using pycountry now. Much simpler.

caseydriscoll commented 10 years ago

Discussed during the sprint 5 planning, before this issue is pushed to master the sign up process should ask for first and last name.

A conversion script should be written to convert existing users 'registration_fullname' to first_name last_name

https://github.com/new-day-international/reddit/issues/196

ffunch commented 10 years ago

OK, so the registration asks for first and last name now, instead of the one field.

There's a conversion script in lib/migrate/names_to_firstlast.py

We'll need to run it, of course, which will be something like:

cd /vagrant/reddit/r2;paster run development.ini r2/lib/migrate/names_to_firstlast.py

or

cd /home/reddit/reddit/r2;paster run production.ini r2/lib/migrate/names_to_firstlast.py

memetic007 commented 10 years ago

I'm not happy with the way that creating and editing the profile information is separate from the display of it.

Creating and editting the profile data is at this URL: http://test.lightnetb.org/prefs/profedit/

While Display of the profile is at this URL: http://test.lightnetb.org/user/Jim_Rutt_Tester_1/

All modern systems (like Facebook) allow "editing in place". That is what I specified in this Issue: