search

new-frontiers-14 / frontier-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
GNU Affero General Public License v3.0
79 stars 463 forks source link

Pen signing fix (Again) #1689

Closed dvir001 closed 1 month ago

dvir001 commented 1 month ago

About the PR

Fix pen sign to always get the right name of the signer. Block ghosts from using the pen More fix ups

Why / Balance

Fixup

How to test

Sign papers, sign papers one after another, no weird name issues

Media

N/A

Breaking changes

N/A

Changelog N/A

dvir001 commented 1 month ago

The change on the crayon charges is good, the ghost issue I can understand, but only seems to be a minor annoyance for admins, regular ghosts shouldn't be able to interact.

As an admin ghost, now signing a particular paper as a particular person now involves creating that person, right?

Looking at it again, I still don't see the issue with the StampDisplayInfo being populated in TrySign - if anything, OnInteractUsing could use work instead of adding an OnPickupHand.

I've tried to remove the reliance on the OnHandPickup, changes up on 2024-07-18-Pen-Suggestions on my repo. Changes vs. master Changes vs. your branch (larger diff, more reversions to tsjip's code)

Give the diff a look when you can, I haven't found any issues with running it locally.

Seems fine