new-frontiers-14 / frontier-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
GNU Affero General Public License v3.0
79 stars 463 forks source link

Allow reapplying approved and denied stamps #1695

Closed whatston3 closed 1 month ago

whatston3 commented 1 month ago

About the PR

Adds a Reapply field to StampComponent, StampDisplayInfo.

Any StampComponent (e.g. on pens, stamps) with their Reapply field set will allow those stamps to be reapplied.

Why / Balance

Finally, papers please RP.

How to test

  1. Spawn approve stamp.
  2. Spawn paper.
  3. Stamp paper multiple times.
  4. View paper. Wow, so many stamps.
  5. Spawn deny stamp.
  6. Spawn paper.
  7. Stamp paper multiple times.
  8. View paper. Wow, so many stamps.
  9. Eject your pen.
  10. Sign paper multiple times.
  11. One signature.
  12. Spawn QM stamp.
  13. Stamp paper multiple times.
  14. One stamp.

Media

approb

Breaking changes

Changelog

:cl:

dvir001 commented 1 month ago

How many times do I need to stamp with auto clicker before the server crash?

whatston3 commented 1 month ago

How many times do I need to stamp with auto clicker before the server crash?

Applied a maximum of 10 stampings for reapplied stamps (currently hardcoded in PaperSystem.cs), added a 1 second delay on stamps (feels reasonable, 1.5 and 2 were a bit long). I've avoided the nasty list check for non-reapplied stamps.

github-actions[bot] commented 1 month ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] commented 1 month ago

RSI Diff Bot; head commit 7d5bb9f80f7285fe447755afa7a33dc6c3c8c612 merging into 1d462cf581bec8ba66cc637b9a75133b265595c6 This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Objects/Misc/bureaucracy.rsi

| State | Old | New | Status | --- | --- | --- | --- | | napkin | ![](https://raw.githubusercontent.com/new-frontiers-14/frontier-station-14/1d462cf581bec8ba66cc637b9a75133b265595c6/Resources/Textures/_NF/Objects/Misc/bureaucracy.rsi/napkin.png) | ![](https://raw.githubusercontent.com/whatston3/frontier-station-14/7d5bb9f80f7285fe447755afa7a33dc6c3c8c612/Resources/Textures/_NF/Objects/Misc/bureaucracy.rsi/napkin.png) | Modified | napkin_words | ![](https://raw.githubusercontent.com/new-frontiers-14/frontier-station-14/1d462cf581bec8ba66cc637b9a75133b265595c6/Resources/Textures/_NF/Objects/Misc/bureaucracy.rsi/napkin_words.png) | ![](https://raw.githubusercontent.com/whatston3/frontier-station-14/7d5bb9f80f7285fe447755afa7a33dc6c3c8c612/Resources/Textures/_NF/Objects/Misc/bureaucracy.rsi/napkin_words.png) | Modified