new-frontiers-14 / frontier-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
GNU Affero General Public License v3.0
79 stars 463 forks source link

Stasis shuttle #1698

Closed dustylens closed 1 week ago

dustylens commented 1 month ago

Medium medical shuttle

About the PR

Adds a new medium-size medical shuttle: the NM Stasis. This ship is a streamlined vessel intended to provide cryo and medical support for large scale disasters. Within the hierarchy of medical responses cryo support is fairly basic medicine, yet has been underrepresented due to its previous immaturity as a gameplay element. The purpose of this shuttle is to provide a civilian avenue to access this medicine without requiring the specific use of medical capital ships.

I believe that this ship will serve in filling a current hole in our ship lineup in addition to providing a great tool for future events where large scale medical response is an economically viable profession.

Why / Balance

Key design points:

Loadout:

Power:

Design:

Final considerations:

How to test

Spawn it, fly it. Not included is a coffee cup to be thrown across the room with disdain.

Media

Pipedream:

ss+(2024-08-25+at+03 25 11)

Lighting w/ nautically appropriate winter theme:

ss+(2024-08-25+at+03 25 30)

stasis

Breaking changes

Changelog

github-actions[bot] commented 1 month ago

RSI Diff Bot; head commit ec68b2fe664f27522790b806c4c6848de54f33b6 merging into ddad6bb1a168e1a7fee3f8711f2e14c77501b292 This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Guidebook/shuttle_maps/128x96.rsi

| State | Old | New | Status | --- | --- | --- | --- | | stasis | ![]() | ![](https://raw.githubusercontent.com/dustylens/frontier-station-14/ec68b2fe664f27522790b806c4c6848de54f33b6/Resources/Textures/_NF/Guidebook/shuttle_maps/128x96.rsi/stasis.png) | Added

Edit: diff updated after ec68b2fe664f27522790b806c4c6848de54f33b6

dvir001 commented 1 month ago

What is a Changelog anyway

github-actions[bot] commented 1 month ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

dvir001 commented 1 month ago

image

No mapping of CMO stamp outside of a locker, also this stamp will end up going away in the future for medical POI head.

dustylens commented 1 month ago

Oddly enough I could not find that stamp anywhere. But it should be removed now. Chalk it up as the one time in SS14 history where the mapper was weird.

dvir001 commented 1 month ago

Locker manual fill? or was it removed? Should have it as a yml spawner.

Cheackraze commented 2 weeks ago

are the pictures up to date? i like the design, the decal work is a bit thick but overall nice attention to detail. I'm not a fan of door placement like this: image

You have a large bay door next to it for exterior access anyway, i dont think the additional airlock is necessary. As long as it passes the guidelines and @MagnusCrowe and @arimah approve it, i think this is a fine addition

dustylens commented 2 weeks ago

The airlock in question has been addressed. To skyline some of the changes so they're not buried in the modernization pass notes.

Removes: Microwave, Exosuit fabricator, redundant access airlock in docking area. Additional plasma fuel.

Tweaks: Swaps paramedic lockers for new cool visual lockers. Chem lab layout tweaked following the removal of the microwave and repurposing of the machine room. Increases price of 42800 base + 15% to 47000. Small change to ship description. Changed classification of the ship to medium.

Adds: Adds a new piped nitrogen tank to better handle atmos impact from cryo refrigeration. New map graphic. New plasma fuel locker. New maintenance locker for misc. tool storage. New placement for tools in the engineering bay. New hydroponics setup in the old engineering room. 3 "anchored" hydroponics bays, botanists locker and seed reclaimer mapped. With the removal of the microwave as a food concern the goal is to allow the ship to produce the materials it requires for its cryo medicine. Leaning into the medical focus ship with a very modest bay. Added medicinal seed crate.

Attached are some images of the areas with the greatest changes and an overall updated image. I appreciate the time and consideration in your feedback @Cheackraze .

I think that should be the tall and short of it. atmos chem ss+(2024-08-20+at+08 10 16)

MagnusCrowe commented 2 weeks ago

image

Did you push your changes?

dustylens commented 2 weeks ago

image

Did you push your changes?

https://github.com/new-frontiers-14/frontier-station-14/pull/1698/commits/a2978a37529b068439775408d96172e8fd3b91f0

Unless I'm very much so mistaken, yes?

price: 47000 #Appraise value 40800 with 15% markup.

MagnusCrowe commented 2 weeks ago

I blame github, I fetched! I swear I fetched and there was no pull! I got it now.

dustylens commented 2 weeks ago

Starting to suspect you're my cardiologist and you're looking for new ways to spike my blood pressure.

MagnusCrowe commented 2 weeks ago

image This makes no sense. A pump pumping into a pump?

image Gyro locker? Generator locker? I feel like there's probably no need for one of these and the other can be moved so it doesn't open up onto an occupied square. image Same deal here with the defib. Perhaps move it down to the empty wall behind the red bench to the south? image Inaccessible air alarm. Perhaps remove the cosmetic poster and put the air alarm there instead? image Inaccessible air alarm. image What is this button supposed to do? image 2 scrubbers in a 2 by 3 room? image 2 scrubbers in a 4 by 4 room? image So much drainage...get rid of the drain in the medical area. Keep the one in chem. image Another spot where functional wall items are placed in inconvenient places while cosmetic items are placed in ideal locations for functional items.

Very good ship. TV works, Can't wait to use it.

dustylens commented 2 weeks ago

ss+(2024-08-21+at+10 49 42)

ss+(2024-08-21+at+10 50 49)

ss+(2024-08-21+at+10 51 07)

I hope that addresses the points raised by you Magnus. Thank you for sharing your time, technical knowledge and eye for detail.

Terrible ship. TV has a Vox screaming about the weather.

dustylens commented 1 week ago

I believe that with the requested changes I've hit the outstanding remaining issues. I'm sure something will come up during the shakedown cruise period.

If there's anything else that I can do before this gets put into the wild or closed forever because it's awful and the worst please let me know. Otherwise I'm going to leave it alone in its post-review state.

arimah commented 1 week ago

I have not had time to look at the updated ship in its entirety; this is not a full review. A minor nitpick:

image This is the wrong type of hydroponics tray. There's one with a suffix, I think it's [Anchored], that we use on ships. Can't be moved or deconstructed. It's the one with the dark frame. Please use that. :)

dustylens commented 1 week ago

You know you are completely right. Which is so odd as I was even in the dev discord chatting with some people about that very thing when we were placing them with an emphasis on using the anchored variety. How peculiar!

I'll get that patched up and send it along in the morning.

By morning I seem to mean 12:11 in the morning.

ss+(2024-08-25+at+12 07 16)