new-frontiers-14 / frontier-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
GNU Affero General Public License v3.0
79 stars 463 forks source link

Chemistry wall locker: rotation fix for opening #1710

Closed whatston3 closed 1 month ago

whatston3 commented 1 month ago

About the PR

Removes fixtures from wall lockers. For whatever reason, the fixture inherited from the base closet prevented the wallmount from aligning its opening arc.

Why / Balance

Caused a bug where filled chemistry lockers could only be opened from the south, regardless of the rotation of the locker.

How to test

  1. Spawn a wall.
  2. Put a filled chemistry locker in the wall facing north (lit panel to the left).
  3. Stand to the north of the wall. You should be able to open the locker.
  4. Stand to the south of the wall. You should not be able to open the locker.
  5. Spawn a medical wall locker, view the PhysicsComponent, confirm there are zero fixtures defined for the object.
  6. Spawn a filled chemistry locker, do the same.

Media

image

Breaking changes

Changelog

:cl: