new-frontiers-14 / frontier-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
GNU Affero General Public License v3.0
79 stars 463 forks source link

Radioactive HyperPacman Generator #1712

Closed dvir001 closed 1 month ago

dvir001 commented 1 month ago

About the PR

Added RadiationSource to new hyper pacman generator, works only when they are running, 0.1 rad per 1 kW.

Can be found in expos on that one tiny rad safe room.

Also small JrPacman buff

Why / Balance

Added a new radiation mini system for portable generators and added it to a new generator to be mapped later.

How to test

Spawn the new generator and let it run

Media

image

image

Breaking changes

N/A

:cl: dvir01

Cheackraze commented 1 month ago

Lots of problems with radiation conceptually, including being absolutely garbage gameplay-wise of having little to no counter play, having no discoverability, and providing hacky workarounds to core gameplay loops, trivializing several key elements of gameplay.

I dont think this is a good change

github-actions[bot] commented 1 month ago

RSI Diff Bot; head commit ca4d5affb2010bd77ba340e991eab42b47285a00 merging into d16f155e8909ef88ae0b326eddf775d4eff34600 This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Structures/Power/Generation/portable_generator.rsi

| State | Old | New | Status | --- | --- | --- | --- | | portgen1 | ![]() | ![](https://raw.githubusercontent.com/dvir001/frontier-station-14/ca4d5affb2010bd77ba340e991eab42b47285a00/Resources/Textures/_NF/Structures/Power/Generation/portable_generator.rsi/portgen1.png) | Added | portgen1on | ![]() | ![](https://raw.githubusercontent.com/dvir001/frontier-station-14/ca4d5affb2010bd77ba340e991eab42b47285a00/Resources/Textures/_NF/Structures/Power/Generation/portable_generator.rsi/portgen1on.png) | Added | portgen_on_unlit | ![]() | ![](https://raw.githubusercontent.com/dvir001/frontier-station-14/ca4d5affb2010bd77ba340e991eab42b47285a00/Resources/Textures/_NF/Structures/Power/Generation/portable_generator.rsi/portgen_on_unlit.png) | Added

Edit: diff updated after ca4d5affb2010bd77ba340e991eab42b47285a00

dvir001 commented 1 month ago

This PR has been fully reworked, moved into new generator.

whatston3 commented 1 month ago

Can't get the game to run on head of branch in local tests, dismissing my approval for now.

whatston3 commented 1 month ago

Gonna merge this, works well, clearly radioactive - if it needs reversion, so be it.