Closed whatston3 closed 1 month ago
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Pushed a few fixes consolidating NFSD loadouts into common groups. Added trenchcoats to detective loadouts, and added mail messenger bag variants to their backpack pool.
Added mask fallbacks (emulating prior survival box behaviour). Unfortunately, this puts a mask on your character, which makes screenshots/previews tricky.
A possible solution is to put the mask in the backpack (won't show up on the paper doll as-is).
About the PR
Uses fallback items as defaults to be selected as defaults for empty or invalid loadouts. For completely empty loadouts, we take as many fallback items exist until we reach the maximum number of supported items per loadout group. For existing loadouts, we assume the user intended to remove items, so we restore a minimal number of items.
Added subgroups to loadoutGroups to reduce redundancy. Subgroups append their loadout entries to the menu in the Character Setup UI, checking the effects on each before being appended. This solves the issues brought up in #1721 regarding the STC shoes needing to copy every entry from the Contractor shoes.
Added "hideEffects" LoadoutEffects to each loadout - these are used both for validation, and to hide entries from the loadout selection window. A harpy character, for instance, shouldn't be presented with options for jumpsuits with pants when they can't ever wear them. Diona also shouldn't be presented with the options for shoes.
Additionally, this PR adds loadout effects for harpy-compatible items to all non-skirt jumpsuits. NOTE: certain items (monastic robes, kilt) should probably be individually marked as HarpyClothing. All shoes have also been marked as invalid for diona.
NOTES:
Why / Balance
1700 provided good motivation to provide medical insurance trackers for default characters, and the discussion motivated the possibility of an encryption key-less loadout.
How to test
Media
The in-game Contractor jumpsuit selection screen for a harpy. Note how no jumpsuits with pants are available.
The in-game Mercenary headgear selection screen for a harpy. The pilot's helmet is being appended from the PilotHead subgroup, and everything below is being appended from the ContractorHead subgroup.
Breaking changes
Changelog
:cl: