Fixes a lot of strange parenting and redundancy in computers. All computers should now inherit from BaseComputer (a computer) instead of BaseStructureComputer (the frame), and many fewer things need to be specified.
ComputerCargoOrders was restored to its upstream component set before the june merge.
Capitalized "bank ATM" and changed wording to "withdraw-only bank ATM". Resolved ATM inheritance order.
Why / Balance
Less object-specific behaviour to maintain, better parenting, cleaner YAML.
I noticed that many of the consoles inheriting from weren't lit up correctly, e.g. the contraband pallet computer, and this stemmed from the inheritance from BaseStructureComputer and the redefinition of fields.
How to test
Find (or spawn) a wallmount ATM (in a wall).
Interact with it.
Remove cash.
Deposit cash.
Go to the station admin console in the SR's office.
Remove cash.
Deposit cash (ensure you have a valid reason and the amount matches what's in the cash slot)
Warp to the Cargo Depot.
Spawn a stack of plasma.
Sell it, it should sell for $954.
Warp to the Trade Outpost.
Check a cargo request computer.
It should be lit up.
Purchase something, it should spawn as normal.
Warp to the NFSD Outpost.
Go to the contraband console.
Spawn a pair of syndie pyjamas on the contraband pallets.
Sell it for 1 FUC.
Media
This shows the lit up state of various consoles. These are all inherited from BaseComputer (apart from the colour of the PointLight on the cargo consoles).
[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase
About the PR
Fixes a lot of strange parenting and redundancy in computers. All computers should now inherit from BaseComputer (a computer) instead of BaseStructureComputer (the frame), and many fewer things need to be specified.
ComputerCargoOrders was restored to its upstream component set before the june merge.
Capitalized "bank ATM" and changed wording to "withdraw-only bank ATM". Resolved ATM inheritance order.
Why / Balance
Less object-specific behaviour to maintain, better parenting, cleaner YAML.
I noticed that many of the consoles inheriting from weren't lit up correctly, e.g. the contraband pallet computer, and this stemmed from the inheritance from BaseStructureComputer and the redefinition of fields.
How to test
Media
This shows the lit up state of various consoles. These are all inherited from BaseComputer (apart from the colour of the PointLight on the cargo consoles).
Breaking changes
Changelog
Mostly internal, no CL.