Closed Tych0theSynth closed 1 month ago
dvir001
commented
1 month ago I actually wanted to have it used also by the mailman since we can lock ships by id ranks and add the mailman ships to it, but we don't have a great shared space for it since the mailman cannot walk into bridge.
Tych0theSynth
commented
1 month ago I actually wanted to have it used also by the mailman since we can lock ships by id ranks and add the mailman ships to it, but we don't have a great shared space for it since the mailman cannot walk into bridge.
I mean I can probably sprite a mail console because the mail totally needs its own drip :godo:
whatston3
commented
1 month ago I mean I can probably sprite a mail console because the mail totally needs its own drip :godo:
I do think one for Frontier staff more generally would be more reasonable. If anything, perhaps the SR console should be resprited, given the giant white "SR" text. Make it the Faze Clan Frontier logo and it's fine, put it in the break room for now?
whatston3
commented
1 month ago Proof of concept with a reduced palette. Most of the colours in the current palette are still from the exclamation point, which I haven't touched.
If this was to be placed in a corner of reception, either by the janitorial office or the plant vendor, it'd be located close to existing shipyard consoles (adjacency, reinforcing association with ships), and be available to all Frontier personnel for ship purchase (multipurpose, reducing redundancy w.r.t mail office console). Should also be tucked away, and shouldn't interfere with traffic through the reception area given its limited use.
Myzumi
commented
1 month ago I actually wanted to have it used also by the mailman since we can lock ships by id ranks and add the mailman ships to it, but we don't have a great shared space for it since the mailman cannot walk into bridge.
What is about the Station Lounge? I believe that room is only accessible by station staff if I'm not wrong
Tych0theSynth
commented
1 month ago Me quietly crying into the void wishing this could've been brought up during the Bottleneck PR or while I was making the sprite :')
Is it worth considering adding it as is so that the SR can get and use the ship until you've all worked out what you'd prefer this console to do?
I have no idea how to code in adding accesses and such. I could probably work it out, but it's not something I'll be able to do for a little while. (It might be faster for someone else to do it). I like the altered sprite.
whatston3
commented
1 month ago Me quietly crying into the void wishing this could've been brought up during the Bottleneck PR or while I was making the sprite :')
Is it worth considering adding it as is so that the SR can get and use the ship until you've all worked out what you'd prefer this console to do?
I have no idea how to code in adding accesses and such. I could probably work it out, but it's not something I'll be able to do for a little while. (It might be faster for someone else to do it). I like the altered sprite.
Can help with this - already exists with the NFSD computers. Don't mean to step on your toes, sorry if I am - still really trying to work out higher-level goals (how many consoles should there be for frontier employees, who should have ships [and if so, which], vouchers, etc.), and unfortunately this PR is opening that can of worms.
whatston3
commented
1 month ago Pushed a small change to restrict the Bottleneck behind SR access - both the Sheriff and SR can buy it, but nobody else (airlocks inside are restricted to command anyways).
Works alright under local tests - shipyard console could use a QoL push to show all ships and disable the purchase button for ones without access. Revert if you aren't fond (sorry if that's the case).
Tych0theSynth
commented
1 month ago Pushed a small change to restrict the Bottleneck behind SR access - both the Sheriff and SR can buy it, but nobody else (airlocks inside are restricted to command anyways).
Works alright under local tests - shipyard console could use a QoL push to show all ships and disable the purchase button for ones without access. Revert if you aren't fond (sorry if that's the case).
All good, and thank you for your help! I'll have a poke around with this over the coming days to get the correct accesses and ships in the console, along with the sprite.
neuPanda
commented
1 month ago Can help with this - already exists with the NFSD computers. Don't mean to step on your toes, sorry if I am - still really trying to work out higher-level goals (how many consoles should there be for frontier employees, who should have ships [and if so, which], vouchers, etc.), and unfortunately this PR is opening that can of worms.
might i propose no new consoles? leave it in the normal console, if your ID does not have access to purchase it, then it will not show up. that said we do not want people stealing the SR's, mail, or other ID while they are trying to buy a ship. i would suggest either giving all station crew access to the STC area and replacing the cargo console in there with a ship yard console, or putting a ship yard console in the break room that is staff only
this way any staff can safely buy any ship without risk of their staff id being stolen while they are looking at the console
as for how to add access, take a look at the NFSD ships. in there they have an access property that you can provide if the shipyard console has that ship in it, it will then check to see if the ID has the access to display that ship this means that an SR, mail, valet, janitor, exc could walk up to any standard ship yard to get their ship alternatively if we do want a shipyard that only has staff ships (which puts all staff at risk if they want to grab a standard ship) we make 1 generic staff shipyard and then like the NFSD ship yard restrict who can see what by access to the ships
neuPanda
commented
1 month ago Works alright under local tests - shipyard console could use a QoL push to show all ships and disable the purchase button for ones without access. Revert if you aren't fond (sorry if that's the case).
not a bad idea 🤔, it would require some finagling and changing the object type passed to include a flag of some sort to identify if it is enabled because right now i think it only passes ships that can be purchased. this way you dont get NFSD ships on the standard shipyard console. 🤷
whatston3
commented
1 month ago Works alright under local tests - shipyard console could use a QoL push to show all ships and disable the purchase button for ones without access. Revert if you aren't fond (sorry if that's the case).
not a bad idea 🤔, it would require some finagling and changing the object type passed to include a flag of some sort to identify if it is enabled because right now i think it only passes ships that can be purchased. this way you dont get NFSD ships on the standard shipyard console. 🤷
FWIW, I've got this up, but it's still a work in progress https://github.com/whatston3/frontier-station-14/tree/2024-07-27-shipyard-ui
Tych0theSynth
commented
1 month ago I do intend to try and work on this some more, but I just do not have the time right now.
whatston3
commented
1 month ago I do intend to try and work on this some more, but I just do not have the time right now.
Honestly, I'll say this is my fault - requesting changes, not making them, and then letting something linger.
Tych0theSynth
commented
1 month ago I do intend to try and work on this some more, but I just do not have the time right now.
Honestly, I'll say this is my fault - requesting changes, not making them, and then letting something linger.
You're fine. It's just a bit more complicated than I'm able to put my mind to right now with IRL stuff going on.
About the PR
Added the SR Shipyard Console from #1580 to Frontier Outpost station map. Now the SR can actually purchase and use the NT Bottleneck.
Why / Balance
Requisite addition for the SR to be able to purchase their exclusive shuttle.
I propose two options for this. (Screenshots of both options in media). THIS PR IS USING OPTION ONE. Option one: The console is placed next to the gun safe in the office. I've therefore also moved the filing cabinet down a bit, and also moved the uniform printer and the table with materials over to where the mail teleporter is located so that corner doesn't feel too cramped.
Option two: The console is placed in the staff lounge next to the SR's bedroom. There's an unused space in the top right corner of that room.
Of course, it could be placed in other locations in different orientations, but the fancy screen sprite is most enjoyed with the console facing south :)
How to test
Get the branch and load the station map.
Media
Option one:
Option two:
Breaking changes
None, I should hope!
Changelog Make sure to take this Changelog template out of the comment block in order for it to show up. :cl: