new-frontiers-14 / frontier-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
GNU Affero General Public License v3.0
87 stars 521 forks source link

Brass Knuckle Melee weapon #1868

Closed VividPups closed 1 month ago

VividPups commented 2 months ago

About the PR

Made a new Melee Glove weapon like the Northstars

Why / Balance

It was requested, check like the idea and there is only 1 item the Northstars that is like this

How to test

spawn it

Media

image image image image image

Changelog. :cl:

VividPups commented 2 months ago

um only put it in here because something is broken and its RSI BS

Edit: well shit

github-actions[bot] commented 2 months ago

RSI Diff Bot; head commit 5108a9a61156e5ba4726f813876ce1af5d0cd6d8 merging into dc3a979fe9fffe007b0a237f6bdceff17db63d74 This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Objects/Weapons/Melee/brassknuckles.rsi

| State | Old | New | Status | --- | --- | --- | --- | | equipped-HAND | ![]() | ![](https://raw.githubusercontent.com/VividPups/frontier-station-14/5108a9a61156e5ba4726f813876ce1af5d0cd6d8/Resources/Textures/_NF/Objects/Weapons/Melee/brassknuckles.rsi/equipped-HAND.png) | Added | icon | ![]() | ![](https://raw.githubusercontent.com/VividPups/frontier-station-14/5108a9a61156e5ba4726f813876ce1af5d0cd6d8/Resources/Textures/_NF/Objects/Weapons/Melee/brassknuckles.rsi/icon.png) | Added | inhand-left | ![]() | ![](https://raw.githubusercontent.com/VividPups/frontier-station-14/5108a9a61156e5ba4726f813876ce1af5d0cd6d8/Resources/Textures/_NF/Objects/Weapons/Melee/brassknuckles.rsi/inhand-left.png) | Added | inhand-right | ![]() | ![](https://raw.githubusercontent.com/VividPups/frontier-station-14/5108a9a61156e5ba4726f813876ce1af5d0cd6d8/Resources/Textures/_NF/Objects/Weapons/Melee/brassknuckles.rsi/inhand-right.png) | Added

Resources/Textures/_NF/Objects/Weapons/Melee/crassknuckles.rsi

| State | Old | New | Status | --- | --- | --- | --- | | equipped-HAND | ![]() | ![](https://raw.githubusercontent.com/VividPups/frontier-station-14/5108a9a61156e5ba4726f813876ce1af5d0cd6d8/Resources/Textures/_NF/Objects/Weapons/Melee/crassknuckles.rsi/equipped-HAND.png) | Added | icon | ![]() | ![](https://raw.githubusercontent.com/VividPups/frontier-station-14/5108a9a61156e5ba4726f813876ce1af5d0cd6d8/Resources/Textures/_NF/Objects/Weapons/Melee/crassknuckles.rsi/icon.png) | Added | inhand-left | ![]() | ![](https://raw.githubusercontent.com/VividPups/frontier-station-14/5108a9a61156e5ba4726f813876ce1af5d0cd6d8/Resources/Textures/_NF/Objects/Weapons/Melee/crassknuckles.rsi/inhand-left.png) | Added | inhand-right | ![]() | ![](https://raw.githubusercontent.com/VividPups/frontier-station-14/5108a9a61156e5ba4726f813876ce1af5d0cd6d8/Resources/Textures/_NF/Objects/Weapons/Melee/crassknuckles.rsi/inhand-right.png) | Added

Edit: diff updated after 5108a9a61156e5ba4726f813876ce1af5d0cd6d8

VividPups commented 2 months ago

Yes I know it looks like a hat

dvir001 commented 2 months ago

Other then the sprite looking a bit too simple (icon) the balance on it is also a bit broken since its using the ClothingHandsGlovesNorthStar as base.

It means it has contraband worth and the syndicate north star scream on it, this should be rebased on the normal boxer gloves.

VividPups commented 2 months ago

Other then the sprite looking a bit too simple (icon) the balance on it is also a bit broken since its using the ClothingHandsGlovesNorthStar as base.

It means it has contraband worth and the syndicate north star scream on it, this should be rebased on the normal boxer gloves.

the Scream is intend, Parent has been change

VividPups commented 2 months ago

scream was removed @dvir001

Everturning commented 2 months ago

I made the sprites from scratch, btw, if it's anything that you need to change attributions wise

whatston3 commented 2 months ago

Sam, I've pushed a set of changes up onto whatston3:brass-knuckles-suggestions for your review. I think I'm happy with the state of that branch, but I'd be curious of your thoughts. Diff of changes here, list below.

image

VividPups commented 2 months ago

weapon is ready for second review

VividPups commented 1 month ago

when it been two days and it still isn't merge : (