new-frontiers-14 / frontier-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
GNU Affero General Public License v3.0
80 stars 465 forks source link

Expedition: Only use bounding box of largest grid for dungeon alignment #1879

Closed whatston3 closed 4 weeks ago

whatston3 commented 4 weeks ago

About the PR

For salvage expeditions, alignment now only considers the largest grid for bounding box alignment.

Why / Balance

Buggy. If bits of the ship fall off, the overall bounding box might be huge, because you flew kilometers away from it. Your ship might then be at one of the corners of that km-wide box, and very far away from the actual dungeon when it spawns.

How to test

  1. Spawn at the Expeditionary Lodge.
  2. Purchase a ship.
  3. Climb aboard, add a lattice extension out from the ship, only needs to be a few tiles.
  4. Snip the lattice from the ship, creating a new grid.
  5. Pilot the ship several hundred meters away from your new grid, making sure not to bring it along with you.
  6. Warp out to expedition.
  7. When you arrive, the dungeon should be close to one of the sides of your ship with this fix. Without the fix, the dungeon will likely be far away (check the transform in the F7 admin panel, dungeon should be close to 0, 0 vs. your ship's coords).

Media

Breaking changes

Changelog

Might not add a changelog for this, difficult to explain. TBD.