new-frontiers-14 / frontier-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
GNU Affero General Public License v3.0
87 stars 521 forks source link

Add reagent spesos value: medicine, blood, elements #1899

Closed Eb- closed 1 month ago

Eb- commented 2 months ago

This is a draft and is very much not ready yet! Values need to be tweaked to disallow money farming. You probably want to wait until this is no longer a draft. Thanks for your patience!

Give reagents (mostly) small pricePerUnit.

todo:

About the PR

Changes many reagents to have a pricePerUnit value. Most reagents before this change were worth nothing.

Please note: I am an inexperienced contributor! Expect silly issues to pop up. I am only comfortable having this merged if things are tested out by a second party and we can ensure that no infinite money loops can be attained.

Why / Balance

This is a change for the Frontier codebase to attempt to make botany and chemistry a little more friendly to those who are starting out. Giving values to not only the base elements, but also to medicines, narcotics, toxins, etc.

Additionally, element reagents bought should have a very small, but present value to help offset costs to a very small percent for unused chemicals

Botanists who end up making, for example, Ambrosia Dues, should get a better value per item rather than say, a banana and berry.

How to test

Run personal server, purchase chemicals at trade, resell them, note the value is a loss. Mix some chemicals, try to make a profit. Especially sell at Cargo for a better return

It should not be possible to make large amounts of money quickly by buying chemicals, mixing them, and then immediately selling them. If a method is found, report this immediately so that it can be addressed!

This also goes for growing plants with strange reagents, the monetary gain should be moderately reasonable, and not a way to get rich quick.

Media

Breaking changes

Changelog

:cl:

dvir001 commented 2 months ago

Chems have no worth right now since they are simple to massive spam and massive farm.

This pr is breaking every point of balance by making the game encourage to mass farm entity.

Or do buy simple chems, combine and sell back on the same POI for infinite cash making.

Not to mention it removes RP worth of selling said entity back to people if someone making meds no longer has worth making them for other peoples

HandsomeTheEgg commented 2 months ago

to be honest , i also had like mentioned this but also more for food chemicals like rice is nothing worth ect...where i can see ts a huge difficulty if you add value to base chems (since you can simple order base chemicals refine and sell for increased price) it would work maybe with stuff like ichor you cant really cultivate or mass farm (cognizine/omnizine could be mass produced but there still if it would be a balanced amount why not ) Cryoxadone for 3.5 speso per units as example would not be so good since you literally can make it out of water if you centrifuge it and with a bluespacebeaker there the trouble comes . if overall chems would be more expensive or you cant just keep buying basic chems to mix it would be easier to balance even the basic chems , but i would atleast cut the basic ones out and only use advanced meds or even harder ones to make at first befor trying to balance even the basic ones around , wouldnt say it removes RP because in the end there people who would bulk sell it because they aim around from the start and only sell if there is demand to people or those who would sell the leftovers because they couldnt sell it to people ( just like if a jug of bruitizine is worth like 3-5k to players it would only be worth like 2.5 speso per unit around 500 for a jug to cargo) it sure needs....a bit more balance but its not a bad thing

Eb- commented 2 months ago

Please remember: This is PR is a draft for a reason! The values are very much flawed at the moment and this is not ready for merge or real review in its current state. I am not looking to add any get rich quick methods of play via this PR and if any are found those should be nerfed into the ground.

My progress on this PR will be slow, as I have other responsibilities in life that I must attend to, I am working on this in my spare time so things will not move fast.

One of the challenges of a change such as this is balancing the numbers, which is what i am currently working on. The ideal sweet spot is simple medications should sell at a loss if bought at trade and sold at cargo, where more advanced medications (in terms of player effort spent) should allow a player to make a minor profit when sold to Cargo, but not trade.


Chems have no worth right now since they are simple to massive spam and massive farm.

This pr is breaking every point of balance by making the game encourage to mass farm entity.

Or do buy simple chems, combine and sell back on the same POI for infinite cash making.

Not to mention it removes RP worth of selling said entity back to people if someone making meds no longer has worth making them for other peoples

I am looking to avoid mass farming! If you can provide some methods where this is possible that i could mitigate i would appreciate it! One of the most important metrics i am looking at is time spent verses money gained. The last thing I want is to discourage Roleplay for players. Ideally selling chemicals to a player should bring in much more money than to trade or cargo.

Currently I have tested buying with simple chems and chem mixing and have sold at a loss at Trade and Cargo. However I have tested Ambrosia Dues and i have made a monster that is worth too much. The values of Desoxyphedrine and Omnizine will be lowered to correct this.


to be honest , i also had like mentioned this but also more for food chemicals like rice is nothing worth ect...where i can see ts a huge difficulty if you add value to base chems (since you can simple order base chemicals refine and sell for increased price) it would work maybe with stuff like ichor you cant really cultivate or mass farm (cognizine/omnizine could be mass produced but there still if it would be a balanced amount why not ) Cryoxadone for 3.5 speso per units as example would not be so good since you literally can make it out of water if you centrifuge it and with a bluespacebeaker there the trouble comes . if overall chems would be more expensive or you cant just keep buying basic chems to mix it would be easier to balance even the basic chems , but i would atleast cut the basic ones out and only use advanced meds or even harder ones to make at first befor trying to balance even the basic ones around , wouldnt say it removes RP because in the end there people who would bulk sell it because they aim around from the start and only sell if there is demand to people or those who would sell the leftovers because they couldnt sell it to people ( just like if a jug of bruitizine is worth like 3-5k to players it would only be worth like 2.5 speso per unit around 500 for a jug to cargo) it sure needs....a bit more balance but its not a bad thing

Very good point on the Cryoxadone! I will lower the value there, thanks!

The last portion you mentioned regarding Bruizine is a great case example of what is desired! Selling to cargo should be much less attractive compared to selling to a player, this is intended. The difficult part is finding the sweet spot for these values.


I encourage comments of potential ways that this system can be cheesed, so that we can avoid any such issues.

github-actions[bot] commented 1 month ago

This pull request has conflicts, please resolve those before we can evaluate the pull request.

dvir001 commented 1 month ago

Reopen if you are still working on this, but if ill be honest this PR create a balance hell to work with.