Military jumpsuits only show patterns on male characters

new-frontiers-14 / frontier-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.

https://spacestation14.io

GNU Affero General Public License v3.0

86 stars 523 forks source link

Military jumpsuits only show patterns on male characters #1959

Open PeccNeck opened 2 months ago

PeccNeck commented 2 months ago

Description

Title. This appears in both the character editor and once spawned in, and for all species (except arachnid).

Reproduction

In job loadouts, select any military jumpsuit
Set your character's sex to Female
The patterns are gone
Spawn in (optional)
The patterns are still gone

Screenshots

Additional context This applies to all job styles; with certain showing as their different "base" colors (e.g. Paramed's will be fully a dark teal, black jumpsuit will, ironically, be fully white).

PeccNeck commented 1 month ago

Bug persists a week later. Poked around in the relevant YML and sprites, couldn't find anything immediately obvious; if this is a C# issue, it's past the extent of my knowledge, or I could just be stupid and be overlooking something somewhere else in YML.

whatston3 commented 1 month ago

Females tend to have displacement maps, and something about the way those work doesn't work well with the way the jumpsuit is layered.

PeccNeck commented 4 days ago

Finally got around to actually poking and looking around; turns out this bug also existed upstream, and was fixed in just two lines by https://github.com/space-wizards/space-station-14/pull/32553. Seems to be already incorporated in #2353, so hopefully we finally see this fixed soon.

Also, as it turns out, it affects other clothing items, too. The issue it mentions specifically calls out colorful costumes, but it even affects the basic colored jumpsuits as well (though it's quite a bit more subtle).