new-frontiers-14 / frontier-station-14

A multiplayer game about paranoia and chaos on a space station. Remake of the cult-classic Space Station 13.
https://spacestation14.io
GNU Affero General Public License v3.0
87 stars 523 forks source link

Multiple shuttles are of incorrect size groups #1962

Open PeccNeck opened 1 month ago

PeccNeck commented 1 month ago

Description

The following vessels currently (potentially) belong to the incorrect size groups:

Reproduction gridtc

Screenshots N/A

Additional context These are based upon solely the tile counts of the Ship Submission Guidelines, wherein:

Size Category | Maximum Tiles | Target Profile Limits -- | -- | -- Micro | 64 | 8 tiles long and 8 tiles wide Small | 256 | 16 tiles long and 16 tiles wide Medium | 1024 | 32 tiles long and 32 tiles wide Large | 2304 | 48 tiles long and 48 tiles wide

Including size limitations, at least one vessel still qualifies (Legman), and I feel like tile limitations are a more reasonable standard in any case. The Pioneer shares the same dimensions as several other Micro vessels (5*9/9*5) and is even 2 tiles smaller than most of them (as multiple share a 45-tile design); so either Pioneer is supposed to be Micro, or every single "Micro" but the Legman, Construct, and Canister belong to Small.

Even if the initial list is wrong, there's definitely inconsistencies to be resolved, and if nothing else, I want to at least highlight that they do exist.

arimah commented 1 month ago

The critical part of the ship submission guidelines is this (emphasis mine):

The length and width should be within that category's target profile limit. If your ship is below the maximum tile limit for a category but exceeds the target profile limit, it belongs to the larger category.

Tile count is not the only way we determine ship size. The Pioneer is small because it's 9 tiles long; the Hammer is medium because it's 17 tiles wide; and so on. Your list would seem to suggest only the Legman is incorrectly classified – thank you for reporting that.

It's funny you bring this up just minutes after I mentioned in the maintainer chat that we might need to have a look at ship sizes!

dustylens commented 1 month ago

The Target Profile Limits are intended to set the uppermost boundary for that size group.

So, as an example, the CAD is currently enjoying a footprint of 37x40. That exceeds the target profile limit of a medium sized grid. It is now classified as a large sized grid.

The maximum tiles is a secondary measure of consideration for grid size relative to footprint. Whichever one is exceeded first takes priority.

Maybe.

arimah commented 1 month ago

Funnily, since the maximum tile count is just the product of the maximum length and width, the maximum tile count is meaningless. The only way to exceed the tile count for any given size category is to exceed its maximum length or width, which automatically puts you in the larger category anyway. C'est la vie.

dustylens commented 1 month ago

The maximum tile count is there to remind us that we should all take exactly what we need and nothing more. The tiles are for all of us to share.

PeccNeck commented 1 month ago

The length and width should be within that category's target profile limit. If your ship is below the maximum tile limit for a category but exceeds the target profile limit, it belongs to the larger category.

Tile count is not the only way we determine ship size. The Pioneer is small because it's 9 tiles long; the Hammer is medium because it's 17 tiles wide; and so on. Your list would seem to suggest only the Legman is incorrectly classified – thank you for reporting that.

Probably should not have missed that part about one setting the larger category over the other. Oops! About the Pioneer, though; again, it's in a weird position, because multiple ships are the same dimensions (5*9) but with a couple tiles more (45) due to sharing a design. These include:

If these are Small as well, that means there are a grand total of 3 Micro ships in the game, and one is a Scrapyard ship (Canister)- which, again, feels super criminal to me, because these ships are tiny, and the area of their dimensions is less than that of Micro's upper limit!

Writing that gave me the idea; what if size is based on the total area as opposed to strict tile count or dimensions? 8*8 is <65, but so is 5*9; while a ship like the Caduceus (37*40) comes up to 1,440, keeping it Large (>1024). Could that work?

DmitriTheDemon commented 1 week ago

I made a draft and included a spreadsheet with the current ship dimensions.