search

new-xkit / XKit

Fork of XKit, the extension framework for Tumblr
https://new-xkit-extension.tumblr.com
Other
459 stars 135 forks source link

Editable Reblogs doubles your post when drafted #100

Open ofinnocxnce opened 9 years ago

ofinnocxnce commented 9 years ago

Okay, so when i go to draft a text post, it basically shows the same thing twice in that reply. Like when for example the text post was "url: oh my god this new xkit is awesome!" and you put it into your drafts it then is "url: oh my god this new xkit is awesome! url: oh my god this new xkit is awesome!"

I hope you get what i mean!

xxastraxx commented 9 years ago

I get the same thing. Also, I can't delete the extra text? I can delete it while editing, but once I save the draft, it's as if I didn't delete anything, and the duplicated text is still there.

OP, what sort of operating system and browser are you using? Maybe we're experiencing similar issues because of that?

I have Windows 7, Firefox 39, and I know everything x-kit is up to date for me....

ofinnocxnce commented 9 years ago

I have Windows 10 and the newest Google Chrome and I at least can edit the drafts and remove the extra text, but it's still annoying

nightpool commented 9 years ago

I'm working on some other fixes for editable reblogs so I'll see if I can get this fixed too.

On Mon, Aug 3, 2015 at 4:02 PM ofinnocxnce notifications@github.com wrote:

I have Windows 10 and the newest Google Chrome and I at least can edit the drafts and remove the extra text, but it's still annoying

— Reply to this email directly or view it on GitHub https://github.com/hobinjk/XKit/issues/100#issuecomment-127405724.

ofinnocxnce commented 9 years ago

Just an update that this doesn't just happen when you draft posts! It also happens when you simply reblog them right away.

nightpool commented 9 years ago

@xxastraxx @ofinnocxnce Can you guys post your xkit extension versions from the "Other" section of the XKit menu? thanks!

image

ofinnocxnce commented 9 years ago

https://gist.github.com/2f648ee9ae0559ca34ab here is mine :)

invalidCards commented 9 years ago

Cannot reproduce. Windows 10, Firefox 39. https://gist.github.com/2e57fa707e0c88a014a2 for extension info.

Sildrael commented 9 years ago

Same problem here, kinda annoying, happens often :/ . Windows 8, newest version of Google Chrome, Here's for the extension info https://gist.github.com/7347091d9264d8255118 <:

WyohKnott commented 9 years ago

@ofinnocxnce @Sildrael I can't reproduce it but can anyone test stuff? When you edit a previous comment in the reblog, does the post saved in the draft then have two identical duplicated text or does it have one original content before editing and one content after editing?

@dlmarquis it's your code, do you think in some circumstance, $(".btn-remove-tree").click(); would not be called and thus keep the original reblog tree?

Also your extension doesn't unregister its callback with XKit.interface.post_window_listener.remove("editable_reblogs"); when destroyed, I don't think it could trigger that bug, but it's worth fixing.

anakhasilver commented 9 years ago

Since mine was closed, adding that it isn't necessarily a drafts issue. http://i.imgur.com/ihCG74K.png This is from my fiancée's RP blog and she did it all on her dashboard.

hobinjk commented 9 years ago

I think I may have found a clue in what is causing this behavior. It looks like Tumblr internally adds the tumblr_blog class to blog links. In the examples I have seen, the only difference between the doubled content is that the first one always has the class and the second always lacks it. I'm going to try adding tumblr_blog in Editable's content html and see what happens.

WyohKnott commented 9 years ago

I don't think that's it, Tumblr has removed the tumblr_blog class a while ago, even on the Drafts I have saved before I had any XKit installed, there isn't that class anymore. If I go to an old blog post with that class still in the body, it automatically gets removed by Tumblr (with no extension enabled).

hobinjk commented 9 years ago

@WyohKnott My reason for saying that is that on http://vozella.tumblr.com/post/126182422090/absolutebell-this-is-strangely-adorable and http://crystalgems.tk/post/126194159741/jxstacomet-snartdonyx-jxstacomet the first occurrence always has it and the second always doesn't. This includes in the reblog_tree and content keys of the v2 api reponses.

I agree that is probably isn't the cause, but I also want to be as thorough as possible.

WyohKnott commented 9 years ago

Oh, no you are probably right then, I checked on the dash only and not on the actual blog pages, where indeed, the tumblr_blog class is still added. This is weird.

And I've just tried to reblog that Vozella post and it added a new copy of the blockquote, while my XKit was off.

invalidCards commented 9 years ago

If needed, another extensions list from a user with this problem. https://gist.github.com/anonymous/6e683bb018c75d5bb60f

invalidCards commented 9 years ago

Might not be Editable Reblogs-related after all.

I do have editable reblogs installed, but not enabled. I just tested and it does the same thing even with editable reblogs uninstalled completely, so it's probably something else that causes the text to disappear. I also noticed the text disappears when you cut and paste it in the same spot, but if you copy the text and paste it under the reply the pasted text stays while the original text disappears.

nightpool commented 9 years ago

@thepsionic it looks like these asks were related to a completely different problem. (specifically, one having to do with one-click-reply)

nightpool commented 9 years ago

@hobinjk I know there was a pull that was supposed to address tumblr_blog class adding—did that not work or did it only work incompletely or what was the deal with that?

hobinjk commented 9 years ago

It did not seem to have any major effect, although I have not looked at the API results with it turned off versus on.

xxastraxx commented 9 years ago

Jeez, I need to check my email more.

I actually fixed the problem entirely by accident? At least for me anyways, there's no knowing if it'd work for others.

I uninstalled the new Xkit entirely from Firefox, and then reinstalled it-- y'know, the classic 'turn it off and back on' fix. I had to re-acquire all my extensions and such, but editable reblogs has worked since then. I know very little of programming, so I've no idea why it worked, but it did....

I can say though, to talk of oddities, that when I uninstalled the old xkit and installed the new one for the first time, my settings were carried over from the old xkit-- much to my surprise. When I uninstalled the new xkit due to this issue just recently, and reinstalled it, I had to set everything up entirely-- as if it was new. It makes me wonder if, at least for me, xcloud messing up something or other was responsible? I know I had the most recent version of the new xkit when I uninstalled it, so I doubt the issues were due to an old version.... But as I said, I know nothing of programming and I don't pretend to-- so I've no idea what in the world any of the above paragraph means. It just seemed relevant to mention.

Let me know if you need more information! I put a reminder in my phone to check my email.

Thanks for all you do, xkit guys. You're incredible!

On Wed, Aug 19, 2015 at 2:30 PM, James Hobin notifications@github.com wrote:

It did not seem to have any major effect, although I have not looked at the API results with it turned off versus on.

— Reply to this email directly or view it on GitHub https://github.com/new-xkit/XKit/issues/100#issuecomment-132733870.

ofinnocxnce commented 9 years ago

After reading that I actually tried the whole completely uninstalling xkit and reinstalling it too! Of course I had to install xkit from scratch, including all the extensions but it fixed the problem for me so i'm more than happy with this.

nightpool commented 9 years ago

If there's anyone that's still experiencing this, can you supply your Full Extension Dump from the Other tab? Thanks!

On Sat, Aug 22, 2015 at 12:56 PM ofinnocxnce notifications@github.com wrote:

After reading that I actually tried the whole completely uninstalling xkit and reinstalling it too! Of course I had to install xkit from scratch, including all the extensions but it fixed the problem for me so i'm more than happy with this.

— Reply to this email directly or view it on GitHub https://github.com/new-xkit/XKit/issues/100#issuecomment-133734836.

GrimmAx commented 9 years ago

Still getting the same problem here, I'm afraid Except it's with regular text posts refpic

KennyVee commented 8 years ago

Still happening -- any movement on this issue yet? I've had to disable editable reblogs because I'm tired of subjecting my followers to doubled posts that can't even be edited down (they can be edited only when Editable Reblogs is disabled).

Configuration export: https://gist.github.com/9d4d1ea6589bd8677e2e

nightpool commented 8 years ago

this should be totally different in the next ER version. we'll deploy that first, and then if this bug still exists we'll take a look.

On Fri, Oct 9, 2015 at 8:30 PM KennyVee notifications@github.com wrote:

Still happening -- any movement on this issue yet? I've had to disable editable reblogs because I'm tired of subjecting my followers to doubled posts that can't even be edited down (they can be edited only when Editable Reblogs is disabled).

Configuration export: https://gist.github.com/9d4d1ea6589bd8677e2e

— Reply to this email directly or view it on GitHub https://github.com/new-xkit/XKit/issues/100#issuecomment-147016755.

invalidCards commented 8 years ago

@nightpool do you know whether this is still a thing? Tumblr had some fuckery on their end a bit ago, but I don't know whether this bug still exists.

nightpool commented 8 years ago

This was fixed in most cases by integrating estufars sidebar fix into main and blacklisting it on /reblog, and will be fixed in the rest of the cases by getting rid of Old Stats

On Fri, Nov 6, 2015 at 10:22 AM ThePsionic notifications@github.com wrote:

@nightpool https://github.com/nightpool do you know whether this is still a thing? Tumblr had some fuckery on their end a bit ago, but I don't know whether this bug still exists.

— Reply to this email directly or view it on GitHub https://github.com/new-xkit/XKit/issues/100#issuecomment-154436467.