search

new-xkit / XKit

Fork of XKit, the extension framework for Tumblr
https://new-xkit-extension.tumblr.com
Other
459 stars 135 forks source link

XCloud large extension skipping broken on old XKit #1099

Closed nightpool closed 7 years ago

nightpool commented 8 years ago

Part of the key XCloud usecase is that it should work well to help users migrate from Old XKit. Currently, large extensions just crash when uploading to the servers, without any indication, just making the progress bar load forever. I believe this happens on new xkit too but I haven't tested it.

the error is "Uncaught ReferenceError: skipping_size is not defined"

I generated 1.5mb of repeating lorem ipsum using python to test this:

s = "Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum."

s += s*(1572864/len(s))

print s
nightpool commented 8 years ago

tagging @ChuckL cause I'm not sure if he follows the repo or not

nightpool commented 8 years ago

Additional "nice to have" follow up here is to make XCloud automatically download its css & icon when it first runs, so users only have to copy the extension js into the editor.

nightpool commented 8 years ago

Bump if anyone has time to contribute a fix--this is pretty high priority, because it affects a large plurality of users, and completely breaks XCloud when they run into it.

nightpool commented 7 years ago

This is fixed by the linting work i'm doing 🙏 🙏 🙏 🙏