search

new-xkit / XKit

Fork of XKit, the extension framework for Tumblr
https://new-xkit-extension.tumblr.com
Other
459 stars 135 forks source link

'Show Originals' extension breaks infinite scrolling #1124

Open AbigailBuccaneer opened 8 years ago

AbigailBuccaneer commented 8 years ago

When I visit the Tumblr dashboard and turn on the 'Originals Only' toggle (or visit it while it's already turned on), my dash is only populated with the posts which were loaded along with the page, and no more are loaded.

A workaround is to turn off 'Originals Only', scroll to the bottom of the page until a screenful of original posts have loaded, and then scroll back to the top of the page and turn it on again. Another is to resize the browser window until the small amount of original posts already there takes up more than a screenful.

Browser: Chromium, Version 51.0.2704.79 Operating system: Ubuntu 16.04 (64-bit) Extension info: https://gist.github.com/9114531d2a6551db6769c1c9302b2184

Screenshot:

image

AbigailBuccaneer commented 8 years ago

It sounds like this may be a regression that was previously fixed by atesh/XKit#151.

nightpool commented 8 years ago

@AbigailBuccaneer regression probably isn't the right word, given that tumblr code is a moving target and things break all the time.

This is part of a general problem with tumblr autoscrolling though. i think I know a good way to fix this...