search

new-xkit / XKit

Fork of XKit, the extension framework for Tumblr
https://new-xkit-extension.tumblr.com
Other
459 stars 135 forks source link

retags on blogs #1132

Open radialarch opened 8 years ago

radialarch commented 8 years ago

maybe not quite a bug per se? but it's not super clear to me the scope of retags, so:

retags is working fine on the dash etc (props, btw!); it also works, if i'm viewing a single post on a particular blog, with the 50 notes that load with the post, which is a little confusing since the console says retags are disabled ("in frame"). but retags will not add tags to any of the notes below the 50 you can see by clicking "load more notes", or whatever.

so like, possibility 1: some kind of post_listener action to fold in further notes, if retags is meant to work on blogs as well as the tumblr pages? or possibility 2: if this is by design/it's technically too complicated, make it clear that retags is limited on blog pages in the extension description?

either is good, really, i'd just like clarification on what the desired behavior is.

nightpool commented 8 years ago

this .... should just work. Its possible we're not adding observers properly on blog pages.

nightpool commented 8 years ago

I can't promise we'll have time to look into this soon (given that it took us two months to just respond to this issue (although I had read it when it came in, I just hadn't written a reply) you have some indication on how long it takes us to get to some things) but it's definitely a nice-to-have fix.