search

new-xkit / XKit

Fork of XKit, the extension framework for Tumblr
https://new-xkit-extension.tumblr.com
Other
459 stars 135 forks source link

Safari storage breaks when encoding non-ascii characters #1178

Closed nightpool closed 8 years ago

nightpool commented 8 years ago

base64-encoding any non-ascii on safari, such as when saving it to storage, will cause a nasty error. This means some extensions can't be loaded on safari, some posts can't be archived, xcloud fails sometimes etc. etc.

I haven't checked recently to confirm this is still an issue, though I doubt it got fixed.

invalidCards commented 8 years ago

I remember there being a unicode issue with extensions - #1081 was made a while ago to fix a similar issue - not sure if it also applies to storage, but sounds likely.

nightpool commented 8 years ago

Yeah, sorry, just made this issue because I knew it was outstanding but I couldn't find a ticket for it. I haven't had a lot of time to look into it, but it definitely has to do with how the safari bridge handles storage.

On Fri, Oct 14, 2016 at 4:53 AM ThePsionic notifications@github.com wrote:

I remember there being a unicode issue with extensions - #1081 https://github.com/new-xkit/XKit/pull/1081 was made a while ago to fix a similar issue - not sure if it also applies to storage, but sounds likely.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/new-xkit/XKit/issues/1178#issuecomment-253744969, or mute the thread https://github.com/notifications/unsubscribe-auth/AAORV18dUg_VxEnFwjae-Hdqz4F9119Gks5qz0MOgaJpZM4KWR78 .