Message Tweaks notification options slightly broken - Githubissues

new-xkit / XKit

Fork of XKit, the extension framework for Tumblr

https://new-xkit-extension.tumblr.com

Other

459 stars 135 forks source link

Message Tweaks notification options slightly broken #1243

Open invalidCards opened 7 years ago

invalidCards commented 7 years ago

Few issues with Message Tweaks' notification options:

The title notification (<[!!]>) is broken in several ways
- For some people, the notification doesn't show up at all
- For others, the notification appears even if there are no new messages (possibly only if you have open chats?)
The desktop notification does not work on Chrome, untested on Firefox
The chat notification sound that plays if you get a new message in an open chat also plays if reloading the page with the chat open

Medium priority because it's a minor annoyance at best.

Wolvan commented 7 years ago

Admittedly I should work on a full rewrite for messaging tweaks, because those things are by far not the only things that are broken. I'll might look into it when I get the chance this or next weekend