search

new-xkit / XKit

Fork of XKit, the extension framework for Tumblr
https://new-xkit-extension.tumblr.com
Other
459 stars 135 forks source link

Sidebar now makes main page entirely invisible #1642

Closed akunohomu closed 5 years ago

akunohomu commented 5 years ago

Previously, opening a blog in the sidebar would add a partially-transparent blue overlay (div class ui_peepr_glass) over the rest of the page. Staff have changed that to be entirely opaque. A tweak to change the transparency of that overlay would be nice; I certainly prefer the old look.

nightpool commented 5 years ago

should be just as simple in the short term as adding body.removeClass('flag--always-opaque-peepr') although the idea that this is an intentional change boggles my mind. We should probably also save the exact styles for posterity:

.peepr .ui_peepr_glass {
    opacity: 1;
}
.ui_peepr_glass {
    background-color: rgba(54,70,93,0.95);
    left: 0;
    opacity: 0;
    right: 0;
    z-index: 998;
    transition: opacity 0.15s;
}
AprilSylph commented 5 years ago

peepr is no longer opaque and flag--always-opaque-peepr no longer exists, resolved

nightpool commented 5 years ago

we waited it out successfully

On Wed, Aug 14, 2019 at 5:13 PM April Sylph notifications@github.com wrote:

peepr is no longer opaque and flag--always-opaque-peepr no longer exists, resolved

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/new-xkit/XKit/issues/1642?email_source=notifications&email_token=AABZCVYR56ZJ777EHMC54FTQERYO7A5CNFSM4GK5QON2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4KEAYI#issuecomment-521420897, or mute the thread https://github.com/notifications/unsubscribe-auth/AABZCV3OGK54RBJBZBRLNPDQERYO7ANCNFSM4GK5QONQ .

AprilSylph commented 5 years ago

if only every other enhancement suggestion could be resolved the same way