new-xkit / XKit

Fork of XKit, the extension framework for Tumblr
https://new-xkit-extension.tumblr.com
Other
459 stars 135 forks source link

Several extensions broken by CORB #1672

Open AprilSylph opened 5 years ago

AprilSylph commented 5 years ago

Chrome's CORB apparently breaks all api.tumblr.com calls, which are included in:

There is also a reference to api.tumblr.com in the bridge, but only as part of HTTPS forwarding - only Post Archiver and Mass+ attempt HTTP connections.

P-Critical due to number of extensions affected and the popularity of Chrome.

nightpool commented 5 years ago

to be more specific, https://www.chromium.org/Home/chromium-security/extension-content-script-fetches breaks all cross-origin calls from content scripts, and api.tumblr.com is our most frequent cross-origin request. There may be others. I'm pretty sure XCloud is broken, for example.

EDIT: Actually it does look like they're respecting access-control-allow-* headers, because installing extensions seems to work. So if XCloud is broken we can just fix it that way. That doesn't rule out other extensions that depend on external resources outside of our control though, which there are probably a few of.

AprilSylph commented 5 years ago

Removing priority label since we are now whitelisted. Issue should be renamed if we want to use this checklist for reducing cross-origin requests. Also removing bug tag since it currently has no actual bearing on the user experience.