search

new-xkit / XKit

Fork of XKit, the extension framework for Tumblr
https://new-xkit-extension.tumblr.com
Other
459 stars 135 forks source link

"No Recommended"'s messages are kinda redundant #1924

Closed nautiscarader closed 4 years ago

nautiscarader commented 4 years ago

dfdsfdsf

So, I noticed today that the No Recommended was updated, and as far as I can see, all it did in frontend was to add the message that a post has been hidden.

Uhm, why?

Unlike the extension that lets you block phrases, I can't see the post again by clicking a button, so... it's kinda redundant and it takes space. Would be nice if one could toggle that line as well.

vexx32 commented 4 years ago

I could be wrong, but I think that was required to prevent breaking the J/K post-by-post scrolling. Something about how it breaks if you completely hide posts or something.

AprilSylph commented 4 years ago

correct, there's no reliable way to completely hide posts without triggering the K-takes-you-to-top bug.

nautiscarader commented 4 years ago

Okay then.

vexx32 commented 4 years ago

It might make sense to put in something similar to the blocked's "show it anyway" for consistency at some point, but given all the other fixes needed it's probably a low priority. 🙂

citrusella commented 4 years ago

Does this cause a bug if you literally never do J/K scrolling? I don't really want to see it and would rather it be hidden, but I could also just hide it on my own (i.e. with CSS)... but I only wanna do that if it doesn't somehow cause an issue while typing a post or reply or something.

citrusella commented 4 years ago

...Also, if this was implemented to fix J/K scrolling, it doesn't appear to have done so anyway unless something else is causing K-to-top on my end...

coderpatsy commented 4 years ago

^ If you have Tumblr Savior's hide sponsored posts option on, it breaks k scrolling.

--

Testing with my own userscript (since xkit's editor is still broken...) shows I can hide the recommended posts entirely without breaking k by making them 0-height 0-margin elements with overflow hidden, as long as I also hide the spacer elements after recommended posts in the middle of the flow the same way. I've only tested on Firefox though.

AprilSylph commented 4 years ago

(@coderpatsy you can still use the xkit editor on firefox, you just need to set accessibility.blockautorefresh to true in about:config)

citrusella commented 4 years ago

@coderpatsy I don't have Tumblr Savior at all, but the mention of sponsored posts reminds me it's possible my adblock could have blocked something? Question mark? So thanks for making me think of that!