This removes the settings page from the list of pages that XKit attempts to exclude itself from running on, and adds some others where it actually might make sense.
This exclusion behavior only happens on initial page load or when you change a setting that Tumblr's React code refreshes the page to apply. Soft navigation within the group of Redpop pages doesn't trigger this test (and it's effectively impossible to have a soft refresh stop XKit scripts that are currently running, anyway, unless you force a hard refresh yourself), so the only effect of trying to exclude the settings page is buggy behavior where XKit suddenly vanishes, and users don't realize that a hard refresh on a non-settings page will bring it back.
No idea what the exclusion list should actually be, realistically. Should XKit run on https://www.tumblr.com/jobs? ¯\_(ツ)_/¯
Look, man, I don't know.
This removes the settings page from the list of pages that XKit attempts to exclude itself from running on, and adds some others where it actually might make sense.
This exclusion behavior only happens on initial page load or when you change a setting that Tumblr's React code refreshes the page to apply. Soft navigation within the group of Redpop pages doesn't trigger this test (and it's effectively impossible to have a soft refresh stop XKit scripts that are currently running, anyway, unless you force a hard refresh yourself), so the only effect of trying to exclude the settings page is buggy behavior where XKit suddenly vanishes, and users don't realize that a hard refresh on a non-settings page will bring it back.
No idea what the exclusion list should actually be, realistically. Should XKit run on https://www.tumblr.com/jobs? ¯\_(ツ)_/¯