new-xkit / XKit

Fork of XKit, the extension framework for Tumblr
https://new-xkit-extension.tumblr.com
Other
460 stars 135 forks source link

Match redpop font weight #2126

Closed marcustyphoon closed 1 year ago

marcustyphoon commented 1 year ago

Low-hanging fruit: this adjusts the XKit button text font to have the same weight as its siblings'.

I could also go put in the different min height and flex gap for pointer: fine, or whatever, but that seemed like a lot of work.

nightpool commented 1 year ago

where are you actually seeing a change here? this is what I see with the default font-weight (which appears to be 400?): image

and this is what I see for 500:

image

maybe you have to load a specific page before the lighter Favorit variant shows up?

marcustyphoon commented 1 year ago

Favorit indeed has very few font weights (which leads the Redpop devs to occasionally set nonsensical-but-arguably-harmless stuff like font-weight: 100). This is only visible if one is overriding the site font, e.g. to Helvetica Neue with Old Blue or Palettes for Tumblr!

nightpool commented 1 year ago

ah, okay