new-xkit / XKit

Fork of XKit, the extension framework for Tumblr
https://new-xkit-extension.tumblr.com
Other
460 stars 135 forks source link

Control button CSS is unreliable #2136

Open marcustyphoon opened 1 year ago

marcustyphoon commented 1 year ago

https://github.com/new-xkit/XKit/blob/13a0fa49c6891395f3d707abaae87504ebcb2f38/Extensions/xkit_patches.js#L970-L997

[data-id]:first footer will not match anything in this code if the first post loaded by the user is a filtered post, which makes "controlIconClass" and "buttonClass" equal to the string 'undefined', which makes post controls look like this:

I assume there's no point in me reporting this, really, since this codebase is super dead and I would be the one fixing it if anyone would, but hey.