search

new-xkit / XKit

Fork of XKit, the extension framework for Tumblr
https://new-xkit-extension.tumblr.com
Other
459 stars 135 forks source link

One-Click Postage: Don't use outdated API endpoint #2137

Open marcustyphoon opened 9 months ago

marcustyphoon commented 9 months ago

One-Click Postage is relatively similar to Quick Reblog in XKit Rewritten, so doing this instead of just breaking it doesn't preserve much functionality (sure, autotagger, multiline captions, yeah, yeah, whatever). I don't see this as as important like I do #2106.

This migrates One-Click Postage to use the modernized backend code that XKit Rewritten's Quick Reblog does instead of the legacy and presumably-someday-removed SVC endpoint when possible (i.e. on React pages).

It removes the share to Twitter/share to Facebook and caption replace options as well as an old option to use a different notification style. Off the top of my head, social media sharing is gone, caption replacing is not a thing post-NPF, and the other notification style didn't work on most pages anyway.

nightpool commented 9 months ago

Is this currently broken? I use OCP pretty often and I haven't noticed anything

marcustyphoon commented 9 months ago

It converts threads to legacy, presumably breaking interoperability with Trim Reblogs. I don't think we want to be doing that.

nightpool commented 9 months ago

The number of people who use OCP and the number of people who use Trim Reblogs, historically, is nowhere near comparable. I don't think we should regress in features for the possibility that 10% of users somewhere might be upset that Trim Reblogs might not work.

Regarding what you wrote in discord, I don't think we should be taking half-joking speculation from two staff members on one potential path for the SVC migration as gospel. I agree we should move to a NPF endpoint for this code eventually, but we should do so in alignment with Tumblr's publicly announced schedule for the deprecation of legacy posts (which will happen eventually, but has not been thoroughly planned out yet.)

On Wed, Sep 27, 2023 at 6:53 PM marcustyphoon @.***> wrote:

It converts threads to legacy, presumably breaking interoperability with Trim Reblogs. I don't think we want to be doing that.

— Reply to this email directly, view it on GitHub https://github.com/new-xkit/XKit/pull/2137#issuecomment-1738253229, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABZCV66QFQAWF7RHZUGZALX4S36NANCNFSM6AAAAAA5I6HEFU . You are receiving this because you commented.Message ID: @.***>

marcustyphoon commented 9 months ago

I don't think we should regress in features

Are we regressing in features?

I don't think we should be taking half-joking speculation from two staff members on one potential path for the SVC migration as gospel. I agree we should move to a NPF endpoint for this code eventually

I guess I don't understand how these two points mesh together :D If we are going to migrate at some point, why not now? If we aren't going to migrate at all, then sure.

It seems to me like I'm viewing the creation of legacy posts as a regression and you're viewing it as a feature; is that accurate?