new-xkit / XKit

Fork of XKit, the extension framework for Tumblr
https://new-xkit-extension.tumblr.com
Other
459 stars 135 forks source link

One-Click Postage: Don't fallback to main blog on failure #2138

Closed marcustyphoon closed 11 months ago

marcustyphoon commented 11 months ago

This removes a mystifying behavior in which One-Click Postage would, on any failure to post, do its single retry attempt with the target blog changed to the user's main.

This is a common complaint when the post author has the user's sideblog blocked. Silently reblogging to the wrong location in this case makes zero sense.

I'm sure there was a reason for this originally (maybe accessing sideblogs was unreliable?) but I can imagine no case in which the post winding up in the wrong place was a good fallback. If you can't do what the user wants, just fail the action. Simple as that.

(I didn't check if this merge conflicts with #2137, but if it does I'll fix the conflict after either is merged. If it matters, of course—I'm not willing to go out of my way to solicit further discussion.)

marcustyphoon commented 11 months ago

Tested by making a post on one of my testing accounts, blocking one of my sideblogs, and attempting to reblog the post onto that sideblog:

Screenshot 2023-10-18 at 7 39 55 PM