new-xkit / XKit

Fork of XKit, the extension framework for Tumblr
https://new-xkit-extension.tumblr.com
Other
459 stars 135 forks source link

One Click Reblog Not Working #76

Closed rhirps closed 9 years ago

rhirps commented 9 years ago

I hover over the reblog button and the screen pops up but when I click the reblog button there all I get is a continuous loading symbol. It won't reblog anything.

NursePhantump commented 9 years ago

Have you uninstalled the old x-kit? If not be sure to do so and that should fix the problem!

eggkin commented 9 years ago

I'm having this problem too, but I've already uninstalled the old xkit and that didn't fix it. I even restarted my entire browser. Windows 10, chrome.

Zarggg commented 9 years ago

I've also noticed this, but haven't been paying close enough attention to what I was doing just before it happens. Windows 10, Firefox.

meiloslyther commented 9 years ago

Having the same problem, even after uninstalling the old xkit. Windows 7, Chrome.

dlmarquis commented 9 years ago

Could be a cache problem. Have you tried clearing the cache?

eggkin commented 9 years ago

Just tried that, restarted browser too, didn't work :/ Maybe it's a windows 10 thing for me? I don't quite know how this stuff works, and I only discovered the new xkit the day after I updated so I dont have any previous knowledge on how it was working.

rhirps commented 9 years ago

I have uninstalled the old xkit. Windows 8.1, Chrome. I cleared the chache and it still didn't work. /:

ceksie commented 9 years ago

i'm on a mac and using chrome and it doesnt work for me either

nightpool commented 9 years ago

can you guys post your xkit and one-click-postage versions? image image

nightpool commented 9 years ago

Also, a list of the extensions you have installed would be helpful.

rhirps commented 9 years ago

screenshot 15 screenshot 16 xinbox, one click postage, one click reply, tweaks, go to das, activity+, anti-capitalism, auto load images, audio downloader, auto tagger, blacklist, classic search, convert links, drafts+, enhanced queue, mass+, mass deleter, no recommended, notification block, notifications+, outbox, post block, quick tags, read more now, reblog as text, reply viewer, reblog yourself, search likes, tag replacer, timestamps, open in tabs, editable reblogs

eggkin commented 9 years ago

Xkit: 7.6.5 One-click postage: 4.0.0 extensions: all the default ones, timestamps, xcloud, tags on sidebar, classic search, reblog yourself, read more now, reblog as text, outbox, drafts+, convert links, blacklist, color quotes, search likes, servant, auto load images, tag replacer, find inactive, separator, view my tags, audio+, notifications+, access kit, open in tabs, mass+, activity+, Xwidgets, profiler, mass deleter, user menus, xstats, view on dash, tagviewer, autotagger, quick tags, enhanced queue, post block, jk across pages, notification block, post archiver, limit people, reply viewer, retags, no recommended, no sidebar, soft refresh, show originals, anti-capitalism, editable reblogs, header options, lethe

some of those I have disabled, however, but those are all the ones installed (disabled: tags on sidebar, classic search, separator, access kit, activity+, view on dash, quick tags, jk across pages, limit people, soft refresh, show originals, header options, lethe)

meiloslyther commented 9 years ago

xkit: 7.6.5 One-click postage: 4.0.0 extensions: xinbox, one-click postage, one-click reply, tweaks, go-to-dash, anti-capitalism, blacklist, audio downloader, auto load images, auto tagger, color quotes, convert links, enhanced queue, no recommended, no sidebar, open in tabs, outbox, profiler, user menus+, quick tags, read more now, reblog as text, reply viewer, retags, tag viewer, timestamps, view on dash, estufar's sidebar fix

nightpool commented 9 years ago

okay these are the extensions you guys all share:

'anti-capitalism', 'auto tagger', 'blacklist', 'convert links', 'editable reblogs',
'enhanced queue', 'no recommended', 'one click postage', 'open in tabs',
'outbox', 'read more now', 'reblog as text', 'reply viewer'

I'll take a look and see if I can reproduce this.

ceksie commented 9 years ago

http://i.gyazo.com/74f8c7cd18ec4efcabb3743b6dd3f087.png http://i.gyazo.com/85ecd6b65f9f51899c05955140e9dff4.png http://i.gyazo.com/016eff5d3e4c5b33b8cb850ebd8a3e98.png

nightpool commented 9 years ago

Okay so just to confirm: for all of you guys, the reblog button won't ever stop the loading animation?

ceksie commented 9 years ago

nope

ceksie commented 9 years ago

at least not as long as i've waited?

rhirps commented 9 years ago

Yes, it won't stop loading.

eggkin commented 9 years ago

like, I get the menu to pop up, hit reblog, and the loading symbol doesnt go away, so yeah.

rhirps commented 9 years ago

Yeah same as eggkin but it doesn't reblog the post at all.

eggkin commented 9 years ago

Yeah, rhirps, that's what I mean, it doesn't reblog, it is eternally trying to process the request.

hobinjk commented 9 years ago

"Not loading" is usually the result of an error being encountered in the API call that sends the post. This may be due to a change in protocol accompanying the Tumblr update

rhirps commented 9 years ago

This problem has been going on since before the update with me.

meiloslyther commented 9 years ago

I'm not sure what update you mean, hobinjk, but this has been going on for at least a week for me, maybe two.

nightpool commented 9 years ago

okay I still can't reproduce this, but here's a modified version of one_click_postage that should give us more information about what problem's you're running into:

https://gist.githubusercontent.com/nightpool/aa763df7f1b700e837fd/raw/56b5d9c8196145d06c3ff2747cd84a953d09832b/one_click_postage.js

unfortunately this is kludgy, but its the only way we have of figuring out what's going on now.

ceksie commented 9 years ago

for me it's still loading like it was before

nightpool commented 9 years ago

@hobinjk i dunno, the onerror handlers for those calls are pretty well populated. there aren't many places that aren't covered by a try/catch block.

nightpool commented 9 years ago

@ceksie if you open up the developer console, (cmd-alt-j) do you see any red errors?

EDIT:you have to be on the tumblr dashboard to see the errors for it.

ceksie commented 9 years ago

yes lots i'll get a pic

ceksie commented 9 years ago

http://gyazo.com/0c9483e0d9cf748f2c92ad86d69f0636

eggkin commented 9 years ago

The edit didn't work for me, I am still getting the same problem.

nightpool commented 9 years ago

Found it! this is a problem with autotagger, but only if you've enabled "replace dashes in the username with spaces"

disable this option for now, and then we'll have a fix out soon that will allow you to re-enable it.

ceksie commented 9 years ago

works now, thanks!

eggkin commented 9 years ago

Works wonderfully now, with that disabled, thanks!

nightpool commented 9 years ago

@hobinjk do we have a translation layer between the returned 'svc/post' models and xkit.interfaces.post objects? it looks like the code assumes they're going to be the same thing. (which is bad for us if tumblr changes any of their API)

hobinjk commented 9 years ago

@nightpool No, if I remember correctly the XKit.interface.post objects are only generated by scraping the ".post" elements whereas svc/post/* can do whatever it wants to. It would definitely be worthwhile to create XKit.interface.post.delete, XKit.interface.post.update, and XKit.interface.post.fetch. The main reason that hasn't already happened is that the object that the svc/post/* methods use is really poorly documented and changes significantly based on what it represents.

hobinjk commented 9 years ago

Closing because this hopefully works now.