Drafts open on the dashboard

[rievna]

When a draft was opened for editing with the old xkit, it would open with the drafts in the background, and when closed, would return one to one's spot inside the drafts folder. Ever since I installed the new xkit, drafts open on the dashboard. When "edit" is clicked, tumblr briefly loads the dash, then opens the draft on top of it. When editing is complete, one has to click back into the drafts. This can be very annoying when working on something in the middle of 100+ drafts and trying to save a copy. Open in Tabs is not installed at all.

[rievna]

Confirmed this is being caused by xkit by disabling all chrome extensions, trying vanilla tumblr, there was no issue. Enable xkit and only xkit, issue occurs.

[nightpool]

which extensions do you have enabled?

On Sat, Aug 1, 2015 at 6:18 AM rievna notifications@github.com wrote:

Confirmed this is being caused by xkit by disabling all chrome extensions, trying vanilla tumblr, there was no issue. Enable xkit, issue occurs.

— Reply to this email directly or view it on GitHub https://github.com/hobinjk/XKit/issues/86#issuecomment-126903555.

[rievna]

Extensions enabled include XInbox, One Click Postage, One Click Reply, Go-to-Dash, Audio+, Auto Load Images, Auto Tagger, Blacklist, Bookmarker, Drafts+, Enhanced Queue, Find Inactives, Glowing Follow, Mass Deleter, Notifications +, Outbox, Post Archiver, Post Crushes, Quick Tags, Read More Now, Read Posts, Reblog as Text, Reblog Yourself, Reply Viewer, Retags, Scroll to Bottom, Tagviewer, Tags on Sidebar, Timestamps, View my Dash, View on Dash, XCloud, Activity+, Postblock, Mass+, Ediable Reblogs, and Tag Replacer.

If you think it's a specific extension I could try disabling all and testing them one by one.

[nightpool]

the only way we can fix something is if we can consistently reproduce it.* Therefore, when we can't reproduce it trivially under a default/"standard" xkit setup, we need more information on your environment to try to replicate the same conditions that break xkit. That's why I asked for your extensions.

I don't really know enough about drafts to give you any real suspects, but maybe try disabling drafts+ I guess? Or editable reblogs.

*: (well, mostly. there are other ways we can try to troubleshoot things, but the common thread in all of them is more information)

On Sun, Aug 2, 2015 at 1:42 AM rievna notifications@github.com wrote:

Extensions enabled include XInbox, One Click Postage, One Click Reply, Go-to-Dash, Audio+, Auto Load Images, Auto Tagger, Blacklist, Bookmarker, Drafts+, Enhanced Queue, Find Inactives, Glowing Follow, Mass Deleter, Notifications +, Outbox, Post Archiver, Post Crushes, Quick Tags, Read More Now, Read Posts, Reblog as Text, Reblog Yourself, Reply Viewer, Retags, Scroll to Bottom, Tagviewer, Tags on Sidebar, Timestamps, View my Dash, View on Dash, XCloud, Activity+, Postblock, Mass+, Ediable Reblogs, and Tag Replacer.

If you think it's a specific extension I could try disabling all and testing them one by one.

— Reply to this email directly or view it on GitHub https://github.com/hobinjk/XKit/issues/86#issuecomment-126995157.

[hobinjk]

Drafts+ appears to do this intentionally, behavior is implemented here

[nightpool]

That's odd... maybe this is behavior from a time before the current tumblr behavior? Or it smooths over certain instabilities that only show up (or used to show up) in the drafting environment?

On Sat, Aug 1, 2015 at 6:18 AM rievna notifications@github.com wrote:

Confirmed this is being caused by xkit by disabling all chrome extensions, trying vanilla tumblr, there was no issue. Enable xkit, issue occurs.

— Reply to this email directly or view it on GitHub https://github.com/hobinjk/XKit/issues/86#issuecomment-126903555.

[rievna]

I've isolated the problem. For me, it's not Drafts+, it's being caused by the "move edit and remove out of the gear" experimental function in Tweaks. I have it unchecked for now and no longer have the problem, however, it is a feature I enjoy and would like to be able to both use it and not be thrown onto the dashboard when editing a draft. I don't know how high experimental functions are on you guys' to-do list though.

[rievna]

Also since disabling that checkmark under Tweaks I reinstalled Drafts+ and it does not dump me on the dashboard but opens the drafts inside the drafts folder as desired, so Drafts+ is confirmed not the cause.

[uranchan]

I have the same problem, it's definitely caused by Tweaks, more exactly by the "Move the edit/remove buttons out of the gear menu" option. If I uncheck that, everything is fine.

[izub]

The problem is that the edit/delete/queue buttons are moved out of the gear menu, but their event listeners are lost in the process. Unfortunately the solution isn't as simple as cloning the buttons.

[invalidCards]

This issue is still prevalent. Tumblr uses some JS to edit the draft within the drafts page, while we send the users to the dashboard and call up the edit screen ourselves.

[nightpool]

@thepsionic that's because the first one isn't "sending" you anywhere. its a pushState history operation

On Fri, Nov 6, 2015 at 10:11 AM ThePsionic notifications@github.com wrote:

This issue is still prevalent; it seems as if the wrong URL is being used to edit the post. Editing a draft without moving the buttons out sends me to https://www.tumblr.com/edit/ while having the tweak on sends me to https://www.tumblr.com/edit/?redirect_to=%2Fblog%2F%2Fdrafts.

— Reply to this email directly or view it on GitHub https://github.com/new-xkit/XKit/issues/86#issuecomment-154433529.

[AprilSylph]

no longer relevant as the split gear tweak is obsolete on the new dashboard and is marked for death removal in #1794; closing