search

newAM / hisensetv

Python API to control Hisense brand TVs via their internal MQTT broker.
MIT License
37 stars 16 forks source link

class Hisense is duplicated #2

Closed ejonesnospam closed 4 years ago

ejonesnospam commented 4 years ago

The definition for class Hisense is duplicated in both files 'init.py' and 'hisensetv.py'.

Unfortunately the updates for volume up/down and ok send keys, was ineffective because the class import used appears to be utilized from 'init.py'.

2 Recommended Options - 1) If duplication is desired, please incorporate updates for volume up/down into 'init.py' as well. 2) If code reduction is desired, I believe the following can be added to 'hisensetv.py'. Then the class Hisense can be removed from 'hisensetv.py' and replace the same definition in 'init.py'

from . import HisenseTv

newAM commented 4 years ago

Oof, that's bone headed mistake on my part, I will remove the hisense.py copy.

newAM commented 4 years ago

Fixed in 163635c3713fa066325b702980a514deda71ea9b