search

newAM / idasen

Python API and CLI for the ikea IDÅSEN desk.
MIT License
119 stars 20 forks source link

add wakeup for the Linak DPG1C controller #370

Closed newAM closed 8 months ago

newAM commented 9 months ago

CC #369

coveralls commented 9 months ago

Coverage Status

coverage: 88.347% (+0.2%) from 88.122% when pulling 419bb6a7606353b304312637af2732fda7a1c42a on add-wakeup into cd43c75b17ef72558d06ff32cbc1c677ea3c5ff7 on main.

newAM commented 9 months ago

@abmantis if you have time your input here would be great since you maintain the HASS component. Do you know of any problems with this approach?

I tried this with my unmodified desk/controller and found no issues sending the wakeup command, but it's always good to double check :)

abmantis commented 8 months ago

Sorry for the delay in replying @newAM ! I will try to test it over the weekend. Is it possible to bump the major version of this lib when releasing this? That way, I can delay HA from using it. I've had quite a few reports from users regarding bluetooth instability (not related to this lib) and have an improvement that I want to get into the next release of HA. I would prefer to avoid adding this as a possible cause of extra unknown issues before the current ones are solved :sweat_smile:

If you are fine with bumping the major version of the lib, than feel free to merge this as it will not affect HA for now! Later, if I find any issues during tests we can work on them :)

datbilling commented 7 months ago

Hi @abmantis, I was just wondering if you had time yet to test this to see if it can be added into HA?

abmantis commented 7 months ago

Hi @abmantis, I was just wondering if you had time yet to test this to see if it can be added into HA?

Yes, it worked fine on my desk (not DPG1C) and should be released with HA 2024.2!

datbilling commented 7 months ago

Hi @abmantis, I was just wondering if you had time yet to test this to see if it can be added into HA?

Yes, it worked fine on my desk (not DPG1C) and should be released with HA 2024.2!

Ok perfect, thank you!