newAM / idasen

Python API and CLI for the ikea IDÅSEN desk.
MIT License
119 stars 20 forks source link

Updated move action to use move characteristic instead of height monitoring #396

Closed sroebert closed 7 months ago

sroebert commented 8 months ago

When moving the desk to a new position, now the move characteristic is used, instead of moving up/down and monitoring the height changes. This results in a consistent height for the desk and making sure the desk always stops at the exact same position, compared to when using height monitoring.

This matches the logic used in: https://github.com/rhyst/linak-controller

I tested it with my own desk and it works perfectly.

coveralls commented 8 months ago

Coverage Status

coverage: 88.736% (+0.4%) from 88.347% when pulling 3fa266b3a635f79984cd7a1c1b40ea163054eeb4 on sroebert:feature/move-to-improvements into 6ab68bcb3cd65a3c91d08324baca1b5a7c6ead14 on newAM:main.