newaetech / chipshouter-picoemp

Why not run micropython on your EMFI tool?
405 stars 52 forks source link

Improved PIO aided triggering (with a delay) #20

Closed nilswiersma closed 1 year ago

nilswiersma commented 2 years ago

Summary of changes:

One downside with fast_trigger is that there is currently not any kind of timeout implemented, so if the input trigger never comes, the serial interface hangs there forever.

Another maybe downside in general is that serial interface is becoming a bit convoluted with all the options and inputs. For example, now there are two configurable pulse_times, one that goes into a sleep_us and one that goes into the PIO program.

nilswiersma commented 1 year ago

Is there anything I could do to help you merge it?

colinoflynn commented 1 year ago

Oops, remembering the existence helps! Merging and will undo if it was a terrible idea, seems sane. Thanks for PR & ping again!