search

newaetech / chipwhisperer

ChipWhisperer - the complete open-source toolchain for side-channel power analysis and glitching attacks
http://chipwhisperer.com
Other
1.12k stars 285 forks source link

External Text Editor parameter does not raise error when invalid #87

Closed FranzHeubach closed 6 years ago

FranzHeubach commented 6 years ago

When setting the External Text Editor parameter within the ChipWhisperer Preferences Window it shows one error to use the default parameter value. This error can be activated by toggling a box that says "do not show me this crap". This box may deactivate the other errors shown when the software tries to open the external editor using this parameter. This errors should be separated and changed so that the error when input a invalid parameter cannot be suppressed leading to confusion later on when the Edit button on the Script Preview Window does not work and there is no error to tell you why it fails.

FranzHeubach commented 6 years ago

I have changed the behavior of defaulting to the default text editor when opening the external text editor fails. It now creates an error window and does not to try to open the default editor anymore unless the external text editor field is empty. The errors still show up in debug logging to distinguish why opening the text editor fails.