newaetech / sonata-pcb

Design files and associated documentation for Sonata PCB, part of the Sunburst Project
Apache License 2.0
12 stars 2 forks source link

KSZ8851SNL missing pull-up resistor for INTRN pin #17

Open nbdd0121 opened 4 months ago

nbdd0121 commented 4 months ago

The INTRN pin of KSZ8851SNL requires an external 4.7kΩ pull-up resistor which is currently missing.

colinoflynn commented 4 months ago

Is turning on the FPGA pull-up sufficient for now? We may be able to fit one as a mod on the PCBs that haven't been sent, but it would better if there was a soft solution for now.

colinoflynn commented 4 months ago

(and if the FPGA pin fix works can just leave it as-is perhaps...)

nbdd0121 commented 4 months ago

Yes FPGA pull-up seems to be working:

https://github.com/lowRISC/sonata-system/blob/990e491575faec4d297f848c5895e2d54fc07695/data/pins_sonata.xdc#L179

Although I am not sure if this matches the 4.7kΩ requirement.

colinoflynn commented 4 months ago

Ok phew! The 4.7kOhm should just affect signal speed I'm guessing (e.g., interrupt may be slower on rising edge). We can add the pads at least I think for next PCB spin, but won't do it as a production mod.

colinoflynn commented 4 months ago

This is now fixed on latest rev (0.9).