search

newaperio / custodian

GitHub bot to manage routine tasks.
https://newaperio.github.io/custodian
MIT License
4 stars 1 forks source link

Custodian removes AND adds "needs review", causing doubled labels #16

Closed Croge32 closed 5 years ago

Croge32 commented 6 years ago

screen shot 2018-01-09 at 3 21 44 pm

ngscheurich commented 6 years ago

@Croge32, can you describe the sequence of events that leads to this issue?

Croge32 commented 6 years ago

@ngscheurich It's easy to see with the Approved and Needs Review too:

1) Make a PR 2) Custodian will add "needs review" 3) After some time, approve PR 4) Custodian seems to add the new correct label (Approved) but adds AND removes old label for some reason (needs review) 5) End up with duplicate labels

screen shot 2018-08-28 at 11 22 16 am

Croge32 commented 6 years ago

I haven't seen the code to know so this is a guess, but maybe the added labels are in an array, and the most previously added label remains in the array when a new label is set to be added?

ngscheurich commented 6 years ago

Perfecto. Thanks for the info. 👍