newaperio / custodian

GitHub bot to manage routine tasks.
https://newaperio.github.io/custodian
MIT License
4 stars 1 forks source link

FunctionClauseError happened in CustodianWeb.WebhookController#receive #7

Closed lleger closed 6 years ago

lleger commented 6 years ago

Message

  HTTP request error: no function clause matching in Custodian.Github.Processor.review/1

Backtrace (last 10 lines)

(custodian) lib/custodian_web/controllers/webhook_controller.ex:13: CustodianWeb.WebhookController.receive/2
(custodian) lib/custodian_web/controllers/webhook_controller.ex:1: CustodianWeb.WebhookController.action/2
(custodian) lib/custodian_web/controllers/webhook_controller.ex:1: CustodianWeb.WebhookController.phoenix_controller_pipeline/2
(custodian) lib/custodian_web/endpoint.ex:1: CustodianWeb.Endpoint.instrument/4
(phoenix) lib/phoenix/router.ex:278: Phoenix.Router.__call__/1
(custodian) lib/custodian_web/endpoint.ex:1: CustodianWeb.Endpoint.plug_builder_call/2
(custodian) lib/custodian_web/endpoint.ex:23: CustodianWeb.Endpoint."call (overridable 2)"/2

View on AppSignal: https://appsignal.com/newaperio-1/sites/5a3d5069ebad6453e56dcad2/incidents/2

lleger commented 6 years ago

This happened because we don’t respond to the commented state on PR reviews. We need to ignore this payload.