search

newaxekub / jmonkeyengine

Automatically exported from code.google.com/p/jmonkeyengine
0 stars 0 forks source link

Hardware Skinning Problems #591

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
The HW skinning patch introduces some problems with current jME3 (even though 
its not turned on).

1) SkeletonControl.setHwSkinning(true) manipulates the vertex buffers even if 
no manipulation is necessary. It should not manipulate buffers at all. All 
manipulations should be done in controlRender(), depending on the value of 
useHwSkinning variable.
2) SkeletonControl.setHwSkinning() can use Material.getParam() to determine if 
NumberOfBones exists on the material, instead of catching the 
IllegalArgumentException.
3) I recommend deferring the decision and the check for HW skinning support for 
later.

See attached document on proposed changes that handle all possible cases 
(created via 4-bit truth table).

Original issue reported on code.google.com by ShadowIs...@gmail.com on 17 Apr 2013 at 7:54

Attachments:

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
Wow...you're back and obnoxious as ever Sheldon...
I think I prefer when you're bored of JME...

Original comment by remy.bou...@gmail.com on 18 Apr 2013 at 5:46