search

newbthenewbd / grav-plugin-tinymce-editor

TinyMCE Editor Integration Plugin for Grav
Other
60 stars 10 forks source link

Retain image upload feature? #1

Closed le717 closed 6 years ago

le717 commented 6 years ago

I'm looking at implementing this plugin for a site I'm transitioning from WordPress to Grav, and so far I am liking it. However, it seems to disable the built-in Grav Admin image uploader. That's kinda an issue for me because my theme makes use of {{ page.media.images|first }} to display a sort of "hero image", and without that uploader, there's no way to do that. Is it possible to retain the image uploader with TinyMCE enabled?

Thanks!

newbthenewbd commented 6 years ago

I've thought about putting the file picker back in there once I figure out how to make it output HTML code rather than Markdown. My reasoning for that, though, was that it's much better than what TinyMCE offers (aka base64 images placed directly in the page's source) when one wants to place multiple same images on a page, or something that isn't an image at all.

Thanks for giving another use case this may have and confirming the demand, added to the To Do section.

Edit: By the way, if You need this ASAP and don't care whether the solution is full-fledged or not, You may remove all the unset-uploads@: true lines from the .yaml files in the blueprints directory. It should temporarily place the file picker back, and as far as I'm aware, even if it disappears again in the next update (if it happens to not yet have this implemented, since the first priority for me right now is to patch up the language shortcodes), the files uploaded will stay.

le717 commented 6 years ago

Thanks for the update and workaround! I may just implement that workaround for the time being. :)

newbthenewbd commented 6 years ago

Implemented in v1.1.0.