search

newbthenewbd / grav-plugin-tinymce-editor

TinyMCE Editor Integration Plugin for Grav
Other
60 stars 10 forks source link

Add default height of editor #13

Closed welcoMattic closed 5 years ago

newbthenewbd commented 6 years ago

Pardon my ignorance, as I'm lately somewhat busy and might therefore fail to notice an elephant in the room, but I'd like to request a clarification - why should a default height be set? I'm not exactly understanding as to why it would be set to 420 pixels, either.

If it's simply a matter of preference, everyone using the plugin should be able to set this up on their own yet, by appending something like this under parameters:

  -
    name: height
    value: '420'

This is not to say that the pull request won't be merged if it's indeed a matter of preference, as the current default height indeed isn't great, but still, I'd prefer to know what's going on first :slightly_smiling_face:

Thanks!

welcoMattic commented 6 years ago

I totally agree that 420 is a dumb default value. The best way is to make this value a parameter like you said.

I'll probably rework on my PR soon ;)

newbthenewbd commented 5 years ago

Starting with v1.2.0, the editor height now directly depends on the content, as the autoresize plugin is now enabled by default, and this pull request has also gotten some quite massive conflicts with tinymce.html.twig that is now unminified, hence closing.

If You believe that the height problem should be solved in a different way, please submit a new pull request or issue.