search

newbthenewbd / grav-plugin-tinymce-editor

TinyMCE Editor Integration Plugin for Grav
Other
60 stars 10 forks source link

Call to a member function folder() on null" #55

Closed eisidor closed 3 years ago

eisidor commented 3 years ago

Call to a member function folder() on null"

Screenshot 2021-02-19 at 11 18 51 Screenshot 2021-02-19 at 11 18 55
newbthenewbd commented 3 years ago

Looks like I am unable to trivially reproduce. Could you please share the steps that lead to the error?

Thanks!

eisidor commented 3 years ago

Looks like I am unable to trivially reproduce. Could you please share the steps that lead to the error?

Thanks!

when I try to save page in other language.

I will back here with a screen record.

eisidor commented 3 years ago

@newbthenewbd here is a video https://streamable.com/k6gweb

newbthenewbd commented 3 years ago

Yeah... weird. Finally managed to reproduce it with Flex Pages disabled, with a page of type Item placed in a Folder, and, as (un)expected, it seems that the essence of the issue is that $page->getOriginal() returns null in these (and similar?) circumstances. It might be a bug in Grav, but I'm not sure.

Had I noticed that the erroring place is actually only this deprecated thing for modifying the old-style absolute links, would have just pushed this workaround earlier, without trying to reproduce - anyways, fixed in v1.3.3, hopefully. :upside_down_face:

Thanks for reporting!